feat(server): Expose total host memory as part of info metrics #4953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The total host memory is expected by some applications such as mastodon to determine if sidekiq is operational. This field is exposed as part of metrics. Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
romange
reviewed
Apr 17, 2025
| @@ -2423,6 +2423,8 @@ string ServerFamily::FormatInfoMetrics(const Metrics& m, std::string_view sectio | |||
| } | |||
| } | |||
| append("table_used_memory", total.table_mem_usage); | |||
| append("total_system_memory", total_host_memory); | |||
There was a problem hiding this comment.
let's take it offline - it's news to me that sidekiq requires it - I want to understand more.
exposing free host memory is tricky - it depends on many environmental factors so I prefer to avoid it if possible
There was a problem hiding this comment.
Sure.
It's not actually sidekiq that needs it, there is a method in a mastodon module that uses the stats to determine whether sidekiq is usable, https://github.com/mastodon/mastodon/blob/main/app/workers/scheduler/self_destruct_scheduler.rb#L22-L26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total host memory is expected by some applications such as mastodon to determine if sidekiq is operational. This field is exposed as part of metrics.
Some context is in #4596 (comment)