ext/curl: deprecate CURLOPT_BINARYTRANSFER

divinity76 · devnexen · commit fc16285538e9 · 2024-01-10T18:16:52.000Z
This is long overdue, CURLOPT_BINARYTRANSFER has been a no-op since PHP5.1.2 in 2004 (ref https://bugs.php.net/bug.php?id=55635 ) Close phpGH-13114.
diff --git a/NEWS b/NEWS
@@ -8,6 +8,9 @@ Core:
   . Enabled ifunc checks on FreeBSD from the 12.x releases. (Freaky)
   . Changed the type of PHP_DEBUG and PHP_ZTS constants to bool. (haszi)
 
+Curl:
+  . Deprecated the CURLOPT_BINARYTRANSFER constant. (divinity76)
+
 Date:
   . Added DateTime[Immutable]::createFromTimestamp. (Marc Bennewitz)
 
diff --git a/UPGRADING b/UPGRADING
@@ -177,6 +177,9 @@ PHP 8.4 UPGRADE NOTES
 4. Deprecated Functionality
 ========================================
 
+- Curl:
+  . The CURLOPT_BINARYTRANSFER constant is deprecated.
+
 - Date:
   . Calling DatePeriod::__construct(string $isostr, int $options = 0) is
     deprecated. Use DatePeriod::createFromISO8601String() instead.
diff --git a/ext/curl/curl.stub.php b/ext/curl/curl.stub.php
@@ -13,6 +13,7 @@
 const CURLOPT_AUTOREFERER = UNKNOWN;
 /**
  * @var int
+ * @deprecated has no effect since 5.1.2
  * @cvalue CURLOPT_BINARYTRANSFER
  */
 const CURLOPT_BINARYTRANSFER = UNKNOWN;
diff --git a/ext/curl/curl_arginfo.h b/ext/curl/curl_arginfo.h
diff --git a/ext/curl/tests/bug46711.phpt b/ext/curl/tests/bug46711.phpt
@@ -20,7 +20,8 @@ foreach( $opt as $option => $value ) {
 var_dump($opt); // with this bug, $opt[58] becomes NULL
 
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: Constant CURLOPT_BINARYTRANSFER is deprecated in %s on line %d
 array(2) {
   [58]=>
   bool(true)
