Skip to content

Commit 822769f

Browse files
authored
missing SKIP_ONLINE_TESTS (php#13155)
* missing SKIP_ONLINE_TESTS gethostbynamel may contact DNS servers, so it should be skipped if SKIP_ONLINE_TESTS , and on a AMD Ryzen 9 7950x WSL Ubuntu this test took ~2 seconds (some DNS timeout i guess?) so it should also have SKIP_SLOW_TESTS * error message nitpick
1 parent 50c51d0 commit 822769f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ext/curl/tests/curl_error_basic.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ Mattijs Hoitink mattijshoitink@gmail.com
77
curl
88
--SKIPIF--
99
<?php
10-
10+
if(getenv("SKIP_ONLINE_TESTS")) die("skip online test");
11+
if(getenv("SKIP_SLOW_TESTS")) die("skip slow test");
1112
$url = "fakeURL";
1213
$ip = gethostbyname($url);
1314
if ($ip != $url) die("skip 'fakeURL' resolves to $ip\n");

0 commit comments

Comments
 (0)