Use ZEND_UNCOMPARABLE for consistency

kocsismate · kocsismate · commit 09c498233eb8 · 2024-08-28T22:39:23.000+02:00
diff --git a/ext/date/php_date.c b/ext/date/php_date.c
@@ -2038,7 +2038,7 @@ static int date_object_compare_timezone(zval *tz1, zval *tz2) /* {{{ */
 
 	if (!o1->initialized || !o2->initialized) {
 		zend_throw_error(date_ce_date_object_error, "Trying to compare uninitialized DateTimeZone objects");
-		return 1;
+		return ZEND_UNCOMPARABLE;
 	}
 
 	if (o1->type != o2->type) {

Original file line number	Diff line number	Diff line change
`@@ -2038,7 +2038,7 @@ static int date_object_compare_timezone(zval tz1, zval tz2) /* {{{ */`
`2038`	`2038`
`2039`	`2039`	`if (!o1->initialized \|\| !o2->initialized) {`
`2040`	`2040`	`zend_throw_error(date_ce_date_object_error, "Trying to compare uninitialized DateTimeZone objects");`
`2041`		`- return 1;`
	`2041`	`+ return ZEND_UNCOMPARABLE;`
`2042`	`2042`	`}`
`2043`	`2043`
`2044`	`2044`	`if (o1->type != o2->type) {`