Skip to content

PDF entry for networking close() slide leads to generic close() slide #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dook97 opened this issue Dec 29, 2023 · 4 comments
Closed

Comments

@Dook97
Copy link

Dook97 commented Dec 29, 2023

In the pdf index under section network programming subtopic close refers to a much earlier place in the document, which talks about general UNIX APIs and not about the relation of close to socket file descriptors etc. which was the intent.

@vladak vladak added bug and removed bug labels Jan 1, 2024
@vladak
Copy link
Member

vladak commented Jan 1, 2024

Thanks for the report. Which version of the PDF (assuming the slides with comments) are you using ?

@Dook97
Copy link
Author

Dook97 commented Jan 1, 2024

The latest release - v99.

@vladak
Copy link
Member

vladak commented Jan 1, 2024

I don't seem to be able to replicate the issue, or maybe I misunderstood the description. Any chance you can show it to me after the lecture ?

@Dook97
Copy link
Author

Dook97 commented Jan 1, 2024

The issue is with the metadata. For example: if you open the pdf in firefox then open the "sections" panel and under the "network programming" section select "close" the document viewer will jump to page 64 instead of 168, which would be the correct destination.

Happens also with zathura, so not a document viewer bug I think.

If you still can't reproduce the issue with this description, I'll be happy to demonstrate after the lecture.

@vladak vladak changed the title Malformed pdf index PDF entry for networking close() slide leads to generic close() slide Jan 8, 2024
@vladak vladak closed this as completed in 41713f8 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants