Skip to content

Add statistical function specifications #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 26, 2020
Merged

Add statistical function specifications #17

merged 10 commits into from
Aug 26, 2020

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Aug 12, 2020 •
edited
Loading

This PR

rgommers
rgommers reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Athan, overall LGTM.

Can you add statistical_reductions to API_specifications/index.rst?

@kgryte kgryte changed the title Add statistical reduction specifications Add statistical functions specifications Aug 17, 2020
@kgryte kgryte changed the title Add statistical functions specifications Add statistical function specifications Aug 17, 2020
@kgryte
Copy link
Contributor Author

kgryte commented Aug 18, 2020

Updated index.rst to link to the specification document for statistical functions.

This PR should now be updated based on review feedback.

rgommers
rgommers approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty straightforward and ready to merge - I'll do so in a couple of days if there are no more comments by then.

@kgryte kgryte mentioned this pull request Aug 26, 2020
Merged
@rgommers rgommers merged commit 79738c1 into master Aug 26, 2020
@rgommers rgommers deleted the statistical-reductions branch August 26, 2020 13:37
@rgommers
Copy link
Member

Okay, in it goes. Thanks @kgryte, and thanks @shoyer for reviewing.

@rgommers rgommers mentioned this pull request Jan 3, 2021
Open
4 tasks
@rgommers rgommers mentioned this pull request Jun 16, 2021
Closed
@kgryte kgryte mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer left review comments

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgryte @rgommers @shoyer