Skip to content

Commit f9fd201

Browse files
refactor(bump): Remove a redundant join call
The list of lines is now joined unconditionally in _bump_with_regex, so there is never a need to join it in update_version_in_files. The removed join was hence a no-op because it was performed on a str.
1 parent b053a7e commit f9fd201

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

commitizen/bump.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def update_version_in_files(
158158

159159
# Write the file out again
160160
with smart_open(filepath, "w") as file:
161-
file.write("".join(version_file))
161+
file.write(version_file)
162162

163163

164164
def _bump_with_regex(

0 commit comments

Comments
 (0)