Skip to content

Commit d36d170

Browse files
davidldayLee-W
authored andcommitted
fix(tests): completed test coverage for npm2
1 parent f50e71e commit d36d170

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

commitizen/providers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ def set_version(self, version: str):
214214
json.dumps(lock_document, indent=self.indent) + "\n"
215215
)
216216
if self.shrinkwrap_file.exists():
217-
shrinkwrap_document = self.set_lock_version(
217+
shrinkwrap_document = self.set_shrinkwrap_version(
218218
json.loads(self.shrinkwrap_file.read_text()), version
219219
)
220220
self.shrinkwrap_file.write_text(

tests/test_version_providers.py

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,20 @@ def test_scm_provider_default_without_commits_and_tags(config: BaseConfig):
278278
}
279279
"""
280280

281+
NPM_NO_VERSION = """\
282+
{
283+
"name": "whatever"
284+
}
285+
"""
286+
287+
NPM_MULTIPLE_VERSIONS = """\
288+
{
289+
"name": "whatever",
290+
"version": "0.1.0",
291+
"version": "0.2.0",
292+
}
293+
"""
294+
281295
NPM2_PROVIDER = [
282296
(
283297
NPM_PACKAGE_JSON,
@@ -348,3 +362,15 @@ def test_npm2_provider(
348362
assert pkg_lock.read_text() == dedent(pkg_lock_expected)
349363
if pkg_shrinkwrap_content:
350364
assert pkg_shrinkwrap.read_text() == dedent(pkg_shrinkwrap_expected)
365+
366+
367+
def test_npm2_exceptions(
368+
config: BaseConfig,
369+
):
370+
config.settings["version_provider"] = "npm2"
371+
provider = get_provider(config)
372+
assert isinstance(provider, Npm2Provider)
373+
with pytest.raises(ValueError):
374+
provider.get_package_version(NPM_NO_VERSION)
375+
with pytest.raises(ValueError):
376+
provider.get_package_version(NPM_MULTIPLE_VERSIONS)

0 commit comments

Comments
 (0)