Skip to content

Commit 7887274

Browse files
adam-grant-hendryLee-W
authored andcommitted
fix: use base config for encoding
Also, use `utf-8` by default on Windows in `out.py`.
1 parent 3e5dd72 commit 7887274

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

commitizen/config/base_config.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
class BaseConfig:
99
def __init__(self):
1010
self._settings: Settings = DEFAULT_SETTINGS.copy()
11-
self._path: Path | None = None
11+
self.encoding = self.settings["encoding"]
12+
self._path: Optional[Path] = None
1213

1314
@property
1415
def settings(self) -> Settings:

commitizen/config/json_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
class JsonConfig(BaseConfig):
1313
def __init__(self, *, data: bytes | str, path: Path | str):
1414
super(JsonConfig, self).__init__()
15-
self.encoding = self.settings["encoding"]
1615
self.is_empty_config = False
1716
self.add_path(path)
1817
self._parse_setting(data)

commitizen/config/toml_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
class TomlConfig(BaseConfig):
1212
def __init__(self, *, data: bytes | str, path: Path | str):
1313
super(TomlConfig, self).__init__()
14-
self.encoding = self.settings["encoding"]
1514
self.is_empty_config = False
1615
self._parse_setting(data)
1716
self.add_path(path)

commitizen/config/yaml_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
class YAMLConfig(BaseConfig):
1313
def __init__(self, *, data: bytes | str, path: Path | str):
1414
super(YAMLConfig, self).__init__()
15-
self.encoding = self.settings["encoding"]
1615
self.is_empty_config = False
1716
self._parse_setting(data)
1817
self.add_path(path)

commitizen/out.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
from termcolor import colored
44

5+
if sys.platform == "win32":
6+
sys.stdout.reconfigure(encoding="utf-8")
7+
58

69
def write(value: str, *args) -> None:
710
"""Intended to be used when value is multiline."""

0 commit comments

Comments
 (0)