Skip to content

Commit 31c570b

Browse files
committed
refactor(exception): Rename CommitFailedError and TagFailedError with Bump prefix
these errors are only for `cz bump`
1 parent 5dfdeeb commit 31c570b

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

commitizen/commands/bump.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
from commitizen.commands.changelog import Changelog
88
from commitizen.config import BaseConfig
99
from commitizen.exceptions import (
10-
CommitFailedError,
10+
BumpCommitFailedError,
11+
BumpTagFailedError,
1112
DryRunExit,
1213
ExpectedExit,
1314
NoCommitsFoundError,
1415
NoPatternMapError,
1516
NoVersionSpecifiedError,
16-
TagFailedError,
1717
)
1818

1919

@@ -151,10 +151,10 @@ def __call__(self): # noqa: C901
151151
self.config.set_key("version", new_version.public)
152152
c = git.commit(message, args=self._get_commit_args())
153153
if c.err:
154-
raise CommitFailedError(f'git.commit error: "{c.err.strip()}"')
154+
raise BumpCommitFailedError(f'git.commit error: "{c.err.strip()}"')
155155
c = git.tag(new_tag_version)
156156
if c.err:
157-
raise TagFailedError(c.err)
157+
raise BumpTagFailedError(c.err)
158158
out.success("Done!")
159159

160160
def _get_commit_args(self):

commitizen/exceptions.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ class ExitCode(enum.IntEnum):
1010
NO_COMMITS_FOUND = 3
1111
NO_VERSION_SPECIFIED = 4
1212
NO_PATTERN_MAP = 5
13-
COMMIT_FAILED = 6
14-
TAG_FAILED = 7
13+
BUMP_COMMIT_FAILED = 6
14+
BUMP_TAG_FAILED = 7
1515
NO_ANSWERS = 8
1616
COMMIT_ERROR = 9
1717
NO_COMMIT_BACKUP = 10
@@ -84,12 +84,12 @@ class NoPatternMapError(CommitizenException):
8484
exit_code = ExitCode.NO_PATTERN_MAP
8585

8686

87-
class CommitFailedError(CommitizenException):
88-
exit_code = ExitCode.COMMIT_FAILED
87+
class BumpCommitFailedError(CommitizenException):
88+
exit_code = ExitCode.BUMP_COMMIT_FAILED
8989

9090

91-
class TagFailedError(CommitizenException):
92-
exit_code = ExitCode.TAG_FAILED
91+
class BumpTagFailedError(CommitizenException):
92+
exit_code = ExitCode.BUMP_TAG_FAILED
9393

9494

9595
class CurrentVersionNotFoundError(CommitizenException):

tests/commands/test_bump_command.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from commitizen import cli, cmd, git
66
from commitizen.exceptions import (
7-
CommitFailedError,
7+
BumpCommitFailedError,
88
CurrentVersionNotFoundError,
99
DryRunExit,
1010
ExpectedExit,
@@ -81,7 +81,7 @@ def test_bump_on_git_with_hooks_no_verify_disabled(mocker):
8181
testargs = ["cz", "bump", "--yes"]
8282
mocker.patch.object(sys, "argv", testargs)
8383

84-
with pytest.raises(CommitFailedError) as excinfo:
84+
with pytest.raises(BumpCommitFailedError) as excinfo:
8585
cli.main()
8686

8787
assert 'git.commit error: "0.1.0"' in str(excinfo.value)

0 commit comments

Comments
 (0)