Skip to content

Commit 7cf4335

Browse files
authored
refactor : dependencies, notifications & instant run
refactor : dependencies, notifications & execute
1 parent 1548722 commit 7cf4335

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+810
-1548
lines changed

CONTRIBUTING.md

+3-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# Studio Contribution Guide
1+
# Code Studio Contribution Guide
22

3-
This page contains guidelines for contributing to the Studio packages. Please review these guidelines before submitting any pull requests to the package.
3+
This page contains guidelines for contributing to the Code Studio packages. Please review these guidelines before submitting any pull requests to the package.
44

55
## Which Branch?
66

@@ -18,10 +18,4 @@ If you have an idea for a new feature you would like to see added to the package
1818

1919
## Coding Guidelines
2020

21-
Studio follows the [PSR-1](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md) and [PSR-4](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-4-autoloader.md) coding standards. In addition to these standards, below is a list of other coding standards that should be followed:
22-
23-
- Namespace declarations should be on the same line as `<?php`.
24-
- Class opening `{` should be on the same line as the class name.
25-
- Function and control structure opening `{` should be on a separate line.
26-
- Interface names are suffixed with `Interface` (`FooInterface`)
27-
- Use tabs instead of 4 spaces.
21+
Code Studio follows the [PSR-1](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md) and [PSR-4](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-4-autoloader.md) and laravel coding standards.

README.md

+16
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,22 @@ All artisan commands can be scheduled. If you want to hide a command from Totem
7878
protected $hidden = true;
7979
```
8080

81+
##### Use one of the following options if you are registering your commands in app/Console/Kernel in L5.4 and below
82+
83+
- Option 1 : Create a array variable, let's say `$artisanCommands` in your app/Providers/AppServiceProvider and list all your commands just like you would do in app/Console/Kernel class. Now in the register method add the following
84+
85+
```
86+
$this->commands($this->artisanCommands);
87+
```
88+
89+
- Option 2: Roll your own ConsoleServiceProvider in app/Providers, create a array variable, let's say `$artisanCommands` and list all your commands just like you would do in app/Console/Kernel class. Now in its register method add the following. Don't forget to add this new provider to config/app.php's providers array.
90+
91+
```
92+
$this->commands($this->artisanCommands);
93+
```
94+
95+
From L5.5 onwards all commands are auto registered, so this wouldn't be a problem.
96+
8197
### Screenshots
8298

8399
##### Task List

composer.json

+9-1
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,22 @@
1616
}
1717
],
1818
"require": {
19-
"php": ">=5.6.4"
19+
"php": ">=5.6.4",
20+
"illuminate/bus":"~5.4.0",
21+
"illuminate/console": "~5.4.0",
22+
"illuminate/contracts": "~5.4.0",
23+
"illuminate/database":"~5.4.0",
24+
"illuminate/events": "~5.4.0"
2025
},
2126
"require-dev": {
2227
"mockery/mockery": "~0.9",
2328
"orchestra/database": "~3.0",
2429
"orchestra/testbench" : "~3.0",
2530
"phpunit/phpunit": "~6.0"
2631
},
32+
"suggest": {
33+
"nexmo/client": "Required for sms notifications."
34+
},
2735
"autoload": {
2836
"psr-4": {
2937
"Studio\\Totem\\": "src/",
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
<?php
2+
3+
use Illuminate\Support\Facades\Schema;
4+
use Illuminate\Database\Schema\Blueprint;
5+
use Illuminate\Database\Migrations\Migration;
6+
7+
class AlterTasksTableAddNotificationsFields extends Migration
8+
{
9+
/**
10+
* Run the migrations.
11+
*
12+
* @return void
13+
*/
14+
public function up()
15+
{
16+
Schema::table('tasks', function (Blueprint $table) {
17+
$table->string('notification_phone_number')->nullable()->after('notification_email_address');
18+
$table->string('notification_slack_webhook')->nullable()->after('notification_phone_number');
19+
});
20+
}
21+
22+
/**
23+
* Reverse the migrations.
24+
*
25+
* @return void
26+
*/
27+
public function down()
28+
{
29+
Schema::table('tasks', function (Blueprint $table) {
30+
$table->dropColumn('notification_phone_number');
31+
$table->dropColumn('notification_slack_webhook');
32+
});
33+
}
34+
}

0 commit comments

Comments
 (0)