some refactoring and cleaning up codes.

Author: omid-ahmadpour

src/Web/Api/Controllers/v1/BaseControllerV1.cs

@@ -4,23 +4,31 @@
     using AutoMapper;
     using MediatR;
     using Microsoft.AspNetCore.Mvc;
+    using Microsoft.Extensions.DependencyInjection;
     using Microsoft.Extensions.Logging;
+    using System;
 
     [ValidateModelState]
     [Route("api/v{version:apiVersion}/[controller]")]
     public class BaseControllerV1 : ControllerBase
     {
-        internal readonly IMediator _mediator;
-        internal readonly IMapper _mapper;
-        internal readonly ILogger _logger;
+        protected IServiceProvider Resolver
+        {
+            get
+            {
+                return HttpContext.RequestServices;
+            }
+        }
 
-        protected BaseControllerV1(ILogger logger,
-                                   IMediator mediator,
-                                   IMapper mapper)
+        protected T GetService<T>()
         {
-            _logger = logger ?? throw new System.ArgumentNullException(nameof(logger));
-            _mediator = mediator ?? throw new System.ArgumentNullException(nameof(mediator));
-            _mapper = mapper ?? throw new System.ArgumentNullException(nameof(mapper));
+            return Resolver.GetService<T>();
         }
+
+        protected IMapper Mapper => GetService<IMapper>();
+
+        protected IMediator Mediator => GetService<IMediator>();
+
+        protected ILogger Logger => GetService<ILogger>();
     }
 }

src/Web/Api/Controllers/v1/Products/ProductController.cs

@@ -15,27 +15,21 @@ namespace CleanTemplate.Api.Controllers.v1.Products
     [ApiVersion("1")]
     public class ProductController : BaseControllerV1
     {
-        public ProductController(ILogger<ProductController> logger,
-                                 IMediator mediator,
-                                 IMapper mapper)
-            : base(logger, mediator, mapper)
-        { }
-
         [HttpGet]
         [SwaggerOperation("get a product by id")]
         public async Task<ApiResult<ProductQueryModel>> GetByIdAsync([FromQuery] int productId)
         {
-            var result = await _mediator.Send(new GetProductByIdQuery() { ProductId = productId });
+            var result = await Mediator.Send(new GetProductByIdQuery() { ProductId = productId });
             return new ApiResult<ProductQueryModel>(result);
         }
 
         [HttpPost]
         [SwaggerOperation("add a product")]
         public async Task<ApiResult<int>> AddAsync(AddProductRequest request)
         {
-            var command = _mapper.Map<AddProductRequest, AddProductCommand>(request);
+            var command = Mapper.Map<AddProductRequest, AddProductCommand>(request);
 
-            var result = await _mediator.Send(command);
+            var result = await Mediator.Send(command);
 
             return new ApiResult<int>(result);
         }
@@ -44,7 +38,7 @@ public async Task<ApiResult<int>> AddAsync(AddProductRequest request)
         [SwaggerOperation("get a product from cache. this is a example for how to use cache")]
         public async Task<ApiResult<ReadProductFromRedisResponse>> ReadFromCacheAsync([FromQuery] int productId)
         {
-            var result = await _mediator.Send(new ReadProductFromRedisQuery(productId));
+            var result = await Mediator.Send(new ReadProductFromRedisQuery(productId));
             return new ApiResult<ReadProductFromRedisResponse>(result);
         }
     }

src/Web/Api/Controllers/v1/Users/UserController.cs

@@ -1,12 +1,9 @@
-using AutoMapper;
-using CleanTemplate.Api.Controllers.v1.Users.Requests;
+using CleanTemplate.Api.Controllers.v1.Users.Requests;
 using CleanTemplate.ApiFramework.Tools;
 using CleanTemplate.Application.Users.Command.CreateUser;
 using CleanTemplate.Application.Users.Command.Login;
-using MediatR;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
-using Microsoft.Extensions.Logging;
 using Swashbuckle.AspNetCore.Annotations;
 using System.Threading;
 using System.Threading.Tasks;
@@ -16,20 +13,14 @@ namespace CleanTemplate.Api.Controllers.v1.Users
     [ApiVersion("1")]
     public class UserController : BaseControllerV1
     {
-        public UserController(ILogger<UserController> logger,
-                              IMediator mediator,
-                              IMapper mapper)
-            : base(logger, mediator, mapper)
-        { }
-
         [HttpPost("signup")]
         [SwaggerOperation("sign up user")]
         [AllowAnonymous]
         public virtual async Task<ApiResult<bool>> SingUpAsync(SingUpRequest request, CancellationToken cancellationToken)
         {
-            var command = _mapper.Map<SingUpRequest, CreateUserCommand>(request);
+            var command = Mapper.Map<SingUpRequest, CreateUserCommand>(request);
 
-            var result = await _mediator.Send(command, cancellationToken);
+            var result = await Mediator.Send(command, cancellationToken);
             return new ApiResult<bool>(result);
         }
 
@@ -38,9 +29,9 @@ public virtual async Task<ApiResult<bool>> SingUpAsync(SingUpRequest request, Ca
         [AllowAnonymous]
         public virtual async Task<ApiResult<LoginResponse>> LoginAsync([FromForm] LoginRequest request, CancellationToken cancellationToken)
         {
-            var command = _mapper.Map<LoginRequest, LoginCommand>(request);
+            var command = Mapper.Map<LoginRequest, LoginCommand>(request);
 
-            var result = await _mediator.Send(command, cancellationToken);
+            var result = await Mediator.Send(command, cancellationToken);
             return new ApiResult<LoginResponse>(result);
         }
     }

test/Api.Test/ProductControllerTest.cs

@@ -13,16 +13,10 @@ namespace CleanTemplate.Api.Test
     public class ProductControllerTest
     {
         ProductController productController;
-        IMediator mediator;
-        ILogger<ProductController> logger;
-        IMapper mapper;
 
         public ProductControllerTest()
         {
-            mediator = new Mock<IMediator>().Object;
-            logger = new Mock<ILogger<ProductController>>().Object;
-            mapper = new Mock<IMapper>().Object;
-            productController = new ProductController(logger, mediator, mapper);
+            productController = new ProductController();
         }
 
         [Theory]