add hasPropertyValue() method

to check if a property has been defined without checking for defaults.

fixes #142

Author: cebe

src/SpecBaseObject.php

@@ -305,11 +305,25 @@ protected function addError(string $error, $class = '')
         $this->_errors[] = end($shortName).$error;
     }
 
+    /**
+     * @param string $name property name.
+     * @return bool true when this object has a property with a non-null value or the property is defined in the OpenAPI spec.
+     * @deprecated since 1.6.0
+     */
     protected function hasProperty(string $name): bool
     {
         return isset($this->_properties[$name]) || isset($this->attributes()[$name]);
     }
 
+    /**
+     * @param string $name property name.
+     * @return bool true, when a property has a non-null value (does not check for default values)
+     */
+    protected function hasPropertyValue(string $name): bool
+    {
+        return isset($this->_properties[$name]);
+    }
+
     protected function requireProperties(array $names)
     {
         foreach ($names as $name) {

src/spec/Schema.php

@@ -127,7 +127,7 @@ protected function attributeDefaults(): array
             // nullable is only relevant, when a type is specified
             // return null as default when there is no type
             // return false as default when there is a type
-            'nullable' => $this->hasProperty('type') ? false : null,
+            'nullable' => $this->hasPropertyValue('type') ? false : null,
         ];
     }
 

tests/spec/SchemaTest.php

@@ -45,11 +45,6 @@ public function testRead()
 
     public function testNullable()
     {
-        self::markTestIncomplete(
-            'Test currently fails as it was not run when https://github.com/cebe/php-openapi/pull/132 was merged. '
-            .'See https://github.com/cebe/php-openapi/issues/142 for status'
-        );
-
         /** @var $schema Schema */
         $schema = Reader::readFromJson('{"type": "string"}', Schema::class);
         $this->assertEquals(Type::STRING, $schema->type);