browserfy -> browserify #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks -- that typo was driving me batty on another branch. I'd definitely be open to PRs fixing the testing environment. It lagged behind and hasn't gotten any love. So go for it! I'll put it on my mental list too (but PRs are very very welcomed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix what I think was a typo.
I also noticed that the test suite setup only works under ruby 1.9.3 and rails 3.2.
That seems like a pretty narrow testing range. Would you be open to PRs testing more versions of both?
(if I actually start using this gem and have time)
Also ruby 1.9.3 is "End Of Life" so you shouldn't really be using it at all.