Skip to content

Commit 7ef08fd

Browse files
authored
Remove dependency on debug (brianc#6)
Accept a `log: (message, other...) => { }` parameter as a config option, but by default use a no-op function instead of debug.
1 parent 276b50d commit 7ef08fd

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

index.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
var genericPool = require('generic-pool')
22
var util = require('util')
33
var EventEmitter = require('events').EventEmitter
4-
var debug = require('debug')
54
var objectAssign = require('object-assign')
65

76
var Pool = module.exports = function (options, Client) {
87
EventEmitter.call(this)
98
this.options = objectAssign({}, options)
10-
this.log = this.options.log || debug('pg:pool')
9+
this.log = this.options.log || function () { }
1110
this.Client = this.options.Client || Client || require('pg').Client
1211
this.Promise = this.options.Promise || Promise
1312

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
"standard-format": "2.2.1"
3737
},
3838
"dependencies": {
39-
"debug": "^2.2.0",
4039
"generic-pool": "2.4.2",
4140
"object-assign": "4.1.0"
4241
}

test/logging.js

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
var expect = require('expect.js')
2+
var co = require('co')
3+
4+
var describe = require('mocha').describe
5+
var it = require('mocha').it
6+
7+
var Pool = require('../')
8+
9+
describe('logging', function () {
10+
it('logs to supplied log function if given', co.wrap(function * () {
11+
var messages = []
12+
var log = function (msg) {
13+
messages.push(msg)
14+
}
15+
var pool = new Pool({ log: log })
16+
yield pool.query('SELECT NOW()')
17+
expect(messages.length).to.be.greaterThan(0)
18+
return pool.end()
19+
}))
20+
})

0 commit comments

Comments
 (0)