Add comments

brianc · brianc · commit 306f5dd49392 · 2013-08-07T15:35:07.000-05:00
diff --git a/lib/result.js b/lib/result.js
@@ -100,6 +100,8 @@ Result.prototype.addFields = function(fieldDescriptions) {
     this.fields.push(desc);
     var parser = types.getTypeParser(desc.dataTypeID, desc.format || 'text');
     this._parsers.push(parser);
+    //this is some craziness to compile the row result parsing
+    //results in ~60% speedup on large query result sets
     ctorBody += "\nthis['" + desc.name + "'] = " + inlineParsers(desc.dataTypeID, i, desc.format) + ';';
   }
   this.RowCtor = Function("parsers", "rowData", ctorBody);

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,8 @@ Result.prototype.addFields = function(fieldDescriptions) {`
`100`	`100`	`this.fields.push(desc);`
`101`	`101`	`var parser = types.getTypeParser(desc.dataTypeID, desc.format \|\| 'text');`
`102`	`102`	`this._parsers.push(parser);`
	`103`	`+ //this is some craziness to compile the row result parsing`
	`104`	`+ //results in ~60% speedup on large query result sets`
`103`	`105`	`ctorBody += "\nthis['" + desc.name + "'] = " + inlineParsers(desc.dataTypeID, i, desc.format) + ';';`
`104`	`106`	`}`
`105`	`107`	`this.RowCtor = Function("parsers", "rowData", ctorBody);`