Remove one deprecated lib and propose another

[mats-nk]

Removed: https://github.com/JHershey69/weatherLocation-Library This is deprecated as Dark Sky is no longer in operation, from authors github description

Propose to add: https://github.com/Bodmer/OpenWeather This Lib uses the free API to OpenWeatherMap. The other "https://github.com/JHershey69/OpenWeatherOneCall" uses the PAY API to OpenWeatherMap.

[github-actions]

Hi @mats-nk.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

[github-actions]

A problem was found with your submission https://github.com/Bodmer/OpenWeather

❌ ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

[github-actions]

Thanks for your interest in contributing to the Arduino Library Manager index @mats-nk
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

• Commit the required change to the branch you submitted this pull request from.
• Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

[per1234]

Hi @mats-nk. We have a policy that libraries can only be removed by request from the maintainer, or in emergency cases with high level approval from Arduino.

So, even though it does seem clear that the library is no longer of value, I don't think I can approve the removal of the "weatherLocation" library unless I receive approval from @JHershey69

But anyone is welcome to submit any library, so it is fine if you want to submit the "OpenWeather" library.

If you would like to continue with the "weatherLocation" library removal attempt, then please submit a separate pull request for the "OpenWeather" library submission. Otherwise you can update this PR if you like.

[JHershey69]

OPENWEATHERONECALL library clearly states “some actions require fees” and the current One Call 3.0 on OPENWEATHER is a subscription service but users get 1000 CALLS A DAY FOR FREE. Which is a weather call once every 15 minutes FOR FREE. The OPENWEATHERONECALL library provides historical weather, and other features not available in BODMER’s OpenWeather Library. Anyone looking for ONLY current weather are free to choose Bodmer’s library but this makes my library no less of a value to Arduino users. Thank you.

[per1234]

Hi @JHershey69. Thanks for your response. The primary focus of this discussion is your "weatherLocation" library:

https://github.com/JHershey69/weatherLocation-Library

@mats-nk is proposing to remove it from Library Manager. As I explained above, Arduino will only remove libraries on request from the library maintainer. So the choice of whether the library will be removed is yours to make. I mentioned you in this discussion in case you might like to comment on that subject.

As for your "OpenWeatherOneCall" library, there is no proposal to remove it. The "OpenWeatherOneCall" library will remain in the Arduino Library Manager regardless of any decision that is made about the "weatherLocation" library.

[JHershey69]

WeatherLocation is clearly deprecated, has been since 2020 when Dark Sky closed. I mentioned OpenWeatherOneCall because it was referenced in the original request, and "Pay Subscription" used as defense for Bodmer's. Bodmer is friend, and has helped me a lot in other areas of the Arduino, and I know he has a library for Open Weather. If he wants it added to the library, I encourage such a move. I'll by him a drink when it propagates. lol. Competition spurs innovation.

[per1234]

WeatherLocation is clearly deprecated, has been since 2020 when Dark Sky closed.

@JHershey69 do you approve the removal of your "weatherLocation" library. Please make sure to format your reply so that there is no ambiguity.

[JHershey69]

I approve the removal of my "weatherLocation" library

(https://github.com/JHershey69/weatherLocation-Library).

[per1234]

OK, thanks!

[per1234]

@mats-nk. Please split this into two separate pull requests:

• remove "weatherLocation" library
• add "OpenWeather" library

Each of those operations is handled in a different way so they must be in separate pull requests.

[mats-nk]

@mats-nk. Please split this into two separate pull requests:

* remove "weatherLocation" library

* add "OpenWeather" library

Each of those operations is handled in a different way so they must be in separate pull requests.

I will do! And I will keep one change = One ticket in the future, should have known better...

And Bodomer has added tags to his Weather library upon my request.

Thx

[mats-nk]

Split

[per1234]

I will keep one change = One ticket in the future, should have known better...

It is fine to combine multiple requests for the same type of operation (e.g., submit multiple libraries) in a single PR if you like. The system is designed to support that. It is only the combination of multiple types of operation (e.g., a submission and a removal) in a single PR that is problematic. But one PR per change is also perfectly fine.

Split

Thanks! I see the PR to submit "OpenWeather" was already accepted, but I didn't see the PR for the removal of the "weatherLocation" library. Were you still planning to submit a PR for that @mats-nk?