Bump github.com/arduino/go-paths-helper from 1.4.0 to 1.6.1 #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://flashblogg.com:443/je/cache.php/https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/arduino/go-paths-helper](https://github.com/arduino/go-paths-helper) from 1.4.0 to 1.6.1. - [Release notes](https://github.com/arduino/go-paths-helper/releases) - [Commits](arduino/go-paths-helper@v1.4.0...v1.6.1) --- updated-dependencies: - dependency-name: github.com/arduino/go-paths-helper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
per1234
force-pushed
the
dependabot/go_modules/github.com/arduino/go-paths-helper-1.6.1
branch
from
0ae8d50 to
0d75f45
Compare
Codecov Report
@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 89.85% 89.83% -0.03%
==========================================
Files 43 43
Lines 6320 6327 +7
==========================================
+ Hits 5679 5684 +5
- Misses 530 531 +1
- Partials 111 112 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The `rulefunction.MissingExamples` function was previously relying on the github.com/arduino/go-paths-helper IsDirCheck() method for two things - Does examples path exist? - Is examples path a folder? The code made the unreasonable assumption that IsDirCheck() would return `false, nil` if the path did not exist, and an error only if some unexpected failure occurred. That is not how IsDirCheck() is intended to work, as is clearly described in its documentation. A bug fix to align the method's behavior with that stated in its docs caused it to correctly return an error when the path did not exist, which caused an inappropriate panic from the `rulefunction.MissingExamples` function when checking an examples folder that did not exist. There is a dedicated method for checking path existence. By calling this method before `IsDirCheck()`, the code can achieve its intended behavior of handling missing examples folders gracefully, only panicing in the event of some unexpected failure that can't be handled without risking spurious linting results.
per1234
force-pushed
the
dependabot/go_modules/github.com/arduino/go-paths-helper-1.6.1
branch
from
f7e4d1d to
26b7c9d
Compare
per1234
approved these changes
Aug 9, 2021
dependabot
bot
deleted the
dependabot/go_modules/github.com/arduino/go-paths-helper-1.6.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/arduino/go-paths-helper from 1.4.0 to 1.6.1.
Commits
43bf0b4Merge pull request #12 from arduino/limit-recursiveness015d6dbCheck IsDir error while doing recursive ReadDirf1671f0Merge pull request #11 from arduino/gzipe27cc55Fixed error msg6afa410fixed tests... oops5a562beAdded GUnzip function3d2c600Merge pull request #9 from arduino/fix_tmp_canonical_pathsbbb420dEnsure canonical path on TempDir()f85d686Ensure canonical path on MkTempDir3054e0eAdded test for canonical tmp path on windowsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)