Skip to content

[skip changelog] Update create changelog action #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

silvanocerza
Copy link
Contributor

The create-changelog action has been updated to support case insensitive regexes, the filter-regex property has been updated accordingly.

@silvanocerza silvanocerza added the type: enhancement Proposed improvement label Jan 4, 2021
@silvanocerza silvanocerza requested a review from per1234 January 4, 2021 16:08
@silvanocerza silvanocerza self-assigned this Jan 4, 2021
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran the workflow it had an error:
https://github.com/per1234/arduino-lint/runs/1648142960?check_suite_focus=true#step:3:15

Error: Invalid flags supplied to RegExp constructor 'true'

@silvanocerza
Copy link
Contributor Author

When I ran the workflow it had an error:
https://github.com/per1234/arduino-lint/runs/1648142960?check_suite_focus=true#step:3:15

Error: Invalid flags supplied to RegExp constructor 'true'

I realize now that I made a mistake in the create-changelog action. 🤦
Will fix it and update the PR.

@silvanocerza silvanocerza force-pushed the scerza/update-create-changelog-action branch from 893e4d8 to ef54daa Compare January 5, 2021 10:00
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the release workflow in my fork and it worked perfectly. Thanks!

@silvanocerza silvanocerza merged commit 0de21f6 into main Jan 7, 2021
@silvanocerza silvanocerza deleted the scerza/update-create-changelog-action branch January 7, 2021 09:27
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants