Skip to content

Documentation and linter setup mismatch #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
jonnybergdahl opened this issue Nov 5, 2023 · 1 comment
Closed
2 tasks done

Documentation and linter setup mismatch #638

jonnybergdahl opened this issue Nov 5, 2023 · 1 comment
Assignees
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@jonnybergdahl
Copy link

Describe the request

The linter have a warning about recommended library name lengths, but the cited documentation says nothing about that. Either the linter setup is wrong, or the documentation is wrong.

Describe the current behavior

Just submit a library with a lengthy library name.

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • My request contains all necessary details
@jonnybergdahl jonnybergdahl added the type: enhancement Proposed improvement label Nov 5, 2023
@per1234 per1234 self-assigned this Nov 5, 2023
@per1234 per1234 transferred this issue from arduino/library-registry Nov 5, 2023
@per1234 per1234 added the topic: code Related to content of the project itself label Nov 5, 2023
@per1234
Copy link
Contributor

per1234 commented Nov 5, 2023

Hi @jonnybergdahl. Thanks for your suggestion. The reference link is provided to help you to understand how the name is defined. The name length recommendation is only that. It is a completely optional suggestion for those who would like to follow best practices (because displaying excessively long arbitrary library names in the UI of Arduino development software such as Arduino IDE and Arduino CLI can be problematic). Although we do hope that library maintainers will heed these recommendations, you are free to disregard it if you like. Warnings do not have any impact on a library's inclusion in Arduino Library Manager.

Either the linter setup is wrong

It is not wrong. Arduino Lint't rule was intentionally configured this way according to best practices recommendations from the developers of the official Arduino development tools.

the documentation is wrong

There is nothing wrong in the linked reference. The best practices optional recommendation for the library name length was intentionally not included in the Arduino Library Specification because this type of suggestion is not appropriate for a formal specification.

It is included in the Arduino Lint documentation:

https://arduino.github.io/arduino-lint/1.2/rules/library/#name-recommended-length-lp010

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2023
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Nov 5, 2023
@arduino arduino locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants