Fix handling of missing lib examples folder

The `rulefunction.MissingExamples` function was previously relying on the github.com/arduino/go-paths-helper IsDirCheck() method for two things

- Does examples path exist?
- Is examples path a folder?

The code made the unreasonable assumption that IsDirCheck() would return `false, nil` if the path did not exist, and an
error only if some unexpected failure occurred. That is not how IsDirCheck() is intended to work, as is clearly described
in its documentation. A bug fix to align the method's behavior with that stated in its docs caused it to correctly return
an error when the path did not exist, which caused an inappropriate panic from the `rulefunction.MissingExamples`
function when checking an examples folder that did not exist.

There is a dedicated method for checking path existence. By calling this method before `IsDirCheck()`, the code can
achieve its intended behavior of handling missing examples folders gracefully, only panicing in the event of some
unexpected failure that can't be handled without risking spurious linting results.

Author: per1234

internal/rule/rulefunction/library.go

@@ -1456,17 +1456,28 @@ func LibraryHasStraySketches() (result ruleresult.Type, output string) {
 func MissingExamples() (result ruleresult.Type, output string) {
 	for _, examplesFolderName := range library.ExamplesFolderSupportedNames() {
 		examplesPath := projectdata.ProjectPath().Join(examplesFolderName)
-		exists, err := examplesPath.IsDirCheck()
+
+		exists, err := examplesPath.ExistCheck()
 		if err != nil {
 			panic(err)
 		}
-		if exists {
-			directoryListing, _ := examplesPath.ReadDirRecursive()
-			directoryListing.FilterDirs()
-			for _, potentialExamplePath := range directoryListing {
-				if sketch.ContainsMainSketchFile(potentialExamplePath) {
-					return ruleresult.Pass, ""
-				}
+		if !exists {
+			continue
+		}
+
+		isDir, err := examplesPath.IsDirCheck()
+		if err != nil {
+			panic(err)
+		}
+		if !isDir {
+			continue
+		}
+
+		directoryListing, _ := examplesPath.ReadDirRecursive()
+		directoryListing.FilterDirs()
+		for _, potentialExamplePath := range directoryListing {
+			if sketch.ContainsMainSketchFile(potentialExamplePath) {
+				return ruleresult.Pass, ""
 			}
 		}
 	}

internal/rule/rulefunction/library_test.go

@@ -952,6 +952,7 @@ func TestLibraryHasStraySketches(t *testing.T) {
 
 func TestMissingExamples(t *testing.T) {
 	testTables := []libraryRuleFunctionTestTable{
+		{"File name collision", "ExamplesFile", ruleresult.Fail, ""},
 		{"Has examples", "ExamplesFolder", ruleresult.Pass, ""},
 		{`Has examples (in "example" folder)`, "ExampleFolder", ruleresult.Pass, ""},
 		{"No examples", "NoExamples", ruleresult.Fail, ""},

internal/rule/rulefunction/testdata/libraries/ExamplesFile/examples

@@ -0,0 +1,9 @@
+name=ExamplesFolder
+version=1.0.0
+author=Cristian Maglie <c.maglie@example.com>, Pippo Pluto <pippo@example.com>
+maintainer=Cristian Maglie <c.maglie@example.com>
+sentence=A library that makes coding a web server a breeze.
+paragraph=Supports HTTP1.1 and you can do GET and POST.
+category=Communication
+url=http://example.com/
+architectures=avr