Skip to content

Added overwrite confirmation to ZIP lib install #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

Added overwrite confirmation to ZIP lib install #212

merged 1 commit into from
Mar 15, 2021

Conversation

kittaakos
Copy link
Contributor

This PR adds support for overwrite confirmation when installing a lib from a zip.

Steps to verify:

  • Install a lib from a zip that was not installed,
  • Install it again,
  • You should see the confirm dialog whether to overwrite or not. If you hit No, nothing happens. If you hit Yes, the existing lib will be overwritten.

Please verify. Thank you!

Signed-off-by: Akos Kitta kittaakos@typefox.io

@kittaakos kittaakos requested a review from per1234 March 12, 2021 14:44
per1234
per1234 requested changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a great improvement.

I made a suggestion for modifying the confirmation dialog text, but the functionality is working perfectly for me.

Added overwrite confirmation to ZIP lib install
c5c1f8f 
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos force-pushed the lib-install-with-overwrite-confirm branch from be5a607 to c5c1f8f Compare March 15, 2021 08:33
@kittaakos
Copy link
Contributor Author

I have updated the PR and force-pushed the requested library -> library folder change. Please verify:

Screen Shot 2021-03-15 at 09 32 48

Thank you!

silvanocerza
silvanocerza approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 👍

per1234
per1234 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos
Copy link
Contributor Author

Thank you for the reviews 👍

@kittaakos kittaakos merged commit 5c8669d into main Mar 15, 2021
@kittaakos kittaakos deleted the lib-install-with-overwrite-confirm branch March 15, 2021 10:22
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @silvanocerza @per1234