Skip to content

ATL-974: Use board search command from the CLI #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

ATL-974: Use board search command from the CLI #203

merged 1 commit into from
Mar 17, 2021

Conversation

kittaakos
Copy link
Contributor

What it does:

  • This PR removes any fuzzy-matching logic from the IDE and switches to the new board search command from the CLI.
  • From now on, the CLI dictates what's the result in the board select dialog.
  • Removes a couple of obsolete code/modules.

Please review. Thank you!

Signed-off-by: Akos Kitta kittaakos@typefox.io

@kittaakos kittaakos requested a review from ubidefeo March 11, 2021 15:43
ubidefeo
ubidefeo approved these changes Mar 16, 2021
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the IDE+CLI PR combo and it does what I expect
Thanks

ATL-974: Use board search command from the CLI
ea36ebc 
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos force-pushed the atl-974--use-fuzzy-from-cli branch from 115f38c to ea36ebc Compare March 17, 2021 09:41
@kittaakos kittaakos merged commit 15b0564 into main Mar 17, 2021
@kittaakos kittaakos deleted the atl-974--use-fuzzy-from-cli branch March 17, 2021 10:41
@per1234 per1234 added topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @ubidefeo @per1234