Add tests for BoardsServiceProvider #1337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevent auto-select of unattached boards Co-authored-by: Francesco Spissu <francescospissu@users.noreply.github.com>
kittaakos
reviewed
Aug 21, 2022
Comment on lines
+370
to
+378
| get latestValidBoardsConfig(): | ||
| | RecursiveRequired<BoardsConfig.Config> | ||
| | undefined { | ||
| return this._latestValidBoardsConfig; | ||
| } | ||
|
|
||
| get latestBoardsConfig(): BoardsConfig.Config | undefined { | ||
| return this._latestBoardsConfig; | ||
| } |
There was a problem hiding this comment.
Do you use public APIs for the tests or do you think this will be used anywhere else in the app?
If the former, I propose using protected and subclass for the tests and increasing the visibility. If the latter, please explain where you plan to use it.
kittaakos
reviewed
Aug 21, 2022
Comment on lines
+141
to
+143
| subject.onAvailablePortsChanged(() => { | ||
| expect(true).to.be.ok; | ||
| }); |
There was a problem hiding this comment.
Does this test fail if the event is not received?
davegarthsimpson
force-pushed
the
180-board-selection
branch
from
d55cd18 to
b7b155c
Compare
davegarthsimpson
added
type: enhancement
|
Closing this PR for now as the tested feature changed substantially since these tests were written. |
per1234
added
conclusion: invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The following tests — marked with 1) and 2) — are failing on the main branch and should succeed here.
Change description
Other information
Reviewer checklist