Skip to content

Dropped compile.optimizeForDebug preference. #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2022
Merged

Dropped compile.optimizeForDebug preference. #1213

merged 1 commit into from
Jul 19, 2022

Conversation

kittaakos
Copy link
Contributor

Closes #1212.

Restored the Optimize for Debugging before:
abca14a02be77160a86d9f4fb6eca8c18d47312d2d4be37c50de50430bbbcd07

Signed-off-by: Akos Kitta a.kitta@arduino.cc

Motivation

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Dropped compile.optimizeForDebug preference.
6a15f10 
Closes #1212.

Restored the `Optimize for Debugging` before:
abca14a02be77160a86d9f4fb6eca8c18d47312d2d4be37c50de50430bbbcd07

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos requested review from fstasi and per1234 July 19, 2022 08:30
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 19, 2022
per1234
per1234 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #1212 for me.

Thanks Akos!

@kittaakos kittaakos merged commit 337d22e into main Jul 19, 2022
@kittaakos kittaakos deleted the #1212 branch July 19, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@fstasi fstasi Awaiting requested review from fstasi

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Optimize for Debugging" state indicator doesn't change from disabled
2 participants
@kittaakos @per1234