Skip to content

Ctrl + Shift + I is mapped twice #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
signed-log opened this issue May 25, 2021 · 3 comments
Closed

Ctrl + Shift + I is mapped twice #390

signed-log opened this issue May 25, 2021 · 3 comments
Assignees
Labels
os: linux Specific to Linux operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@signed-log
Copy link

Describe the bug

Ctrl + Shift + I should be mapped as Format Document but it is also mapped to Toggle Library Manager View

To Reproduce

  1. Do the combination

Expected behavior

It should format the file, not open the Library Manager view or the opposite (which it does but it must be made clearer)

Screenshots

Library

Format

Desktop (please complete the following information):

  • OS: OpenSUSE Tumbleweed 20210522
  • Version: 2.0.0-beta.7
@kittaakos
Copy link
Contributor

Ctrl + Shift + I should be mapped as Format Document

Out of curiosity, why do you suggest it should map like that? Ctrl/Cmd + T is the format document. CtrlCmd + Shift + I was always Toggle Library View. I think we should rebind the default format document command, that comes from Theia, to CtrlCmd + T so that we provide the same UX as the Java-based Arduino IDE.

@signed-log
Copy link
Author

Hello,
The fun thing is that the arduino-native format command is alread mapped to CtrlCmd + T (command name arduino-auto-format), but the Theia-native takes preference when not using the Tools menu but using the F1 as it doesn't appear as a command here.

Frankly, both would be good to me, but I would prefer the Theia-Native shortcut as I use more VSCode than the Java IDE

@cmaglie cmaglie removed the type: bug label Sep 16, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 added os: linux Specific to Linux operating system topic: code Related to content of the project itself labels Oct 25, 2021
@ubidefeo
Copy link

The format command in IDE 2.0 will remain CTRL/CMD + T and Theia's "format document" command (accessible from the command palette) is not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: linux Specific to Linux operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

6 participants