Skip to content

Closing the Search tab should clear highlighting in editors (or hide them) #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ubidefeo opened this issue Mar 19, 2021 · 0 comments
Open

Closing the Search tab should clear highlighting in editors (or hide them) #241

ubidefeo opened this issue Mar 19, 2021 · 0 comments
Assignees
@fstasi
Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@ubidefeo
Copy link

Describe the bug
When I use the new Search tab it highlights the found instances in any open editor, but once I close the tab the highlight remains, causing a confusing scenario

To Reproduce
Steps to reproduce the behavior:

  1. open the search tab
  2. search for something which is in your code (any tab)
  3. Close the search sidebar
  4. look at the text still be highlighted

Expected behavior
two options:

  • clearing the search field on close
  • hiding the highlight and show it again when the tab is open

Screenshots
Screenshot 2021-03-19 at 09 29 34
Screenshot 2021-03-19 at 09 29 54

Desktop (please complete the following information):

  • OS: Mac OS 10.15.7
  • Version: 2.0.0 Beta 4
@ubidefeo ubidefeo added type: bug priority: medium Resolution is a medium priority and removed type: bug labels Mar 19, 2021
@kittaakos kittaakos removed their assignment Jul 18, 2021
@cmaglie cmaglie removed the type: bug label Sep 16, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 28, 2021
@rsora rsora added criticality: medium Of moderate impact and removed priority: medium Resolution is a medium priority labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fstasi fstasi

Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cmaglie @kittaakos @fstasi @ubidefeo @per1234 @rsora