Skip to content

Tab selection partially lost on rename #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
per1234 opened this issue Mar 14, 2021 · 0 comments
Open

Tab selection partially lost on rename #219

per1234 opened this issue Mar 14, 2021 · 0 comments
Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Mar 14, 2021

Describe the bug

🐛 When a tab is renamed, the adjacent one is functionally selected, even though the renamed one is visually selected.

To Reproduce

  1. Click the downward pointing triangle button on the right side of the tab bar.
  2. Click "New Tab"
  3. In the "Name for new file" dialog, type foo.h
  4. Click the OK button.
  5. Click the downward pointing triangle button on the right side of the tab bar.
  6. Click "New Tab"
  7. In the "Name for new file" dialog, type bar
  8. Click the OK button.
  9. Click the downward pointing triangle button on the right side of the tab bar.
  10. Click "Rename"
  11. In the "Name for new file" dialog, type baz
  12. Click the OK button.
    🐛 Note that the window title now shows that the "foo.h" is selected, but the GUI shows that "baz.ino" is selected.
  13. Press Ctrl+F
    🐛 Note that the "Find" GUI does not appear
  14. Click on the "foo.h" tab.
    🐛 Note that the top and bottom of the "Find" GUI are missing:
    Clipboard01

Expected behavior

The renamed tab to remain fully selected.

Desktop

  • OS: Windows 10
  • Version: 2.0.0-beta.3-nightly.20210313
    Date: 2021-03-13T03:11:23.309Z
    CLI Version: 0.16.1 alpha [76f55490]

Additional context

The addition of the "foo.h" tab is not required. I added that step to the demo because the window title only shows file names when a non-.ino file is selected, so the demonstration is not so clear with a sketch that only contains .ino files.

@per1234 per1234 added type: bug topic: code Related to content of the project itself labels Mar 14, 2021
@ubidefeo ubidefeo added the priority: medium Resolution is a medium priority label Mar 19, 2021
@kittaakos kittaakos removed their assignment Jul 18, 2021
@cmaglie cmaglie removed the type: bug label Sep 16, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@rsora rsora added criticality: medium Of moderate impact and removed priority: medium Resolution is a medium priority labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

5 participants