Handle redirects for Yun shield sketch upload #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Mistry <s.mistry@arduino.cc>
Signed-off-by: Sandeep Mistry <s.mistry@arduino.cc>
| // Don't forget to close the multipart writer. | ||
| // If you don't close it, your request will be missing the terminating boundary. | ||
| w.Close() | ||
| var cookies []*http.Cookie |
There was a problem hiding this comment.
Why does it need cookies?
There was a problem hiding this comment.
If you don't set a cookie from the 302 response, you keep on redirecting.
We need to discuss this behaviour with @facchinm.
|
The only problem I see here is that the Yun101 (or a Yun updated to fw 1.6.2) will not respond a |
|
@facchinm yes, it responds with a 404, and we fallback to SSH mode. |
matteosuppo
force-pushed
the
devel
branch
4 times, most recently
from
fee3d17 to
b0b3b31
Compare
|
The support for Yun Shield was never completed, so we're closing this PR. RIP. |
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When POST'ing a sketch for upload to
/data/upload_sketch_silent, it returns a 302 Found response with a Location of/cgi-bin/luci/;stok=<stok>/data/upload_sketch_silent. The Go HTTP client will attempt to do a GET request for this redirect (instead of POST) and get a 401 response because there is no Authentication header in the request.This change will make
spProgramNetworkPOST a new request to the redirected URL when this condition is encountered.It would be nice to change the behaviour of the Yun Shield REST service to not redirect, because the sketch data is sent twice over the network. If this is not possible, then we can use this patch instead.
cc/ @facchinm @matteosuppo