Skip to content

use eToken for signing #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2024
Merged

use eToken for signing #950

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da6bb8c
fix typo
umbynos May 9, 2024
1ebbd6b
use eToken for signing, create a dedicated step for signing
umbynos May 13, 2024
752aca5
update workflow, we have a certificate and no longer a container for win
umbynos May 13, 2024
7d2ec28
env var $GITHUB_REF not expanded in step input causing workflow to fail
umbynos May 15, 2024
29c73a2
bump runner, so that we get an updated version of openssl
umbynos May 15, 2024
a2d247b
add flag to correctly recognize the algorithm
umbynos May 15, 2024
03c77c4
remove double quotes, they cause errors with new version of openssl:
umbynos May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove double quotes, they cause errors with new version of openssl: 
`Could not read certificate from <stdin>`
  • Loading branch information
@umbynos
umbynos committed May 15, 2024
commit 03c77c4677869dcf9bc6fc57a454b54a9bfd3c91
4 changes: 2 additions & 2 deletions .github/workflows/check-certificates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
EXPIRATION_DATE="$(
(
openssl pkcs12 \
-in "${{ env.CERTIFICATE_PATH }}" \
-in ${{ env.CERTIFICATE_PATH }} \
-clcerts \
-nodes \
-passin env:CERTIFICATE_PASSWORD \
Expand All @@ -111,7 +111,7 @@ jobs:
EXPIRATION_DATE="$(
(
openssl x509 \
-in "${{ env.CERTIFICATE_PATH }}" \
-in ${{ env.CERTIFICATE_PATH }} \
-noout \
-enddate
) | (
Expand Down
Loading