Skip to content

bugfix: serial enumerator failures in some rare circumstances #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 14, 2023
Merged

bugfix: serial enumerator failures in some rare circumstances #830

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b5be9f
Use io.Discard instead of custom nullWriter
cmaglie Sep 12, 2023
ec6f5fe
Renamed and slightly refactored port enumerators
cmaglie Sep 12, 2023
a2b9f11
Useless code beautify
cmaglie Sep 12, 2023
694398d
Updated go.bug.st/serial lib to 1.6.0
cmaglie Sep 12, 2023
c1f7818
Empty port list if the enumerator fails
cmaglie Sep 13, 2023
decd813
Synchronize multiple serial-port update request
cmaglie Sep 13, 2023
2deef95
Upgraded go-serial to 1.6.1
cmaglie Sep 14, 2023
faf57f6
Update serial.go
cmaglie Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Synchronize multiple serial-port update request
  • Loading branch information
@cmaglie
cmaglie committed Sep 13, 2023
commit decd8134b23636c48994172217728e765e676365
6 changes: 6 additions & 0 deletions serial.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,13 @@ func discoverLoop() {
}()
}

var serialEnumeratorLock sync.Mutex

func updateSerialPortList() {
if !serialEnumeratorLock.TryLock() {
return
}
defer serialEnumeratorLock.Unlock()
ports, err := enumerateSerialPorts()
if err != nil {
// TODO: report error?
Expand Down