Sync "Check Certificates" GitHub Actions workflow with template #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the naming convention established in the standardized template workflow.
The `repository_dispatch` event allows triggering workflows via the GitHub API. This might be useful for triggering an immediate check in multiple relevant repositories after an external change, or some automated process. Although we don't have any specific need for this event at the moment, the event has no impact on the workflow, so there is no reason against having it. It is the sort of thing that can end up being useful if it is already in consistently in place, but not worth setting up on demand, since the effort to set it up is greater than the effort to trigger all the workflows manually.
This will facilitate testing and review of modifications to the workflow. Because the workflow requires access to repository secrets, and so will fail whenever triggered by an event from a fork, a conditional is added to make it only run when the modifications are made within the `arduino/arduino-create-agent` repository.
No functional change, and neither is necessarily superior, but this is how it is in the "template", and so it must be here as well.
When no name is provided for a matrix job, the workflow job is named according to the contents of `jobs[].<job_id>.strategy.matrix[]`. That can result in some fairly cryptic job names when the matrix contains a complex data structure as is the case here. We already have a string to uniquely identify each certificate to humans, which is exactly what the `jobs[].<job_id>.name` property does for jobs, so it will be an improvement to name the jobs according to that identifier.
No functional change, and neither is necessarily superior, but this is how it is in the "template", and so it must be here as well.
This will make it easier for the maintainers to sync fixes and improvements in either direction between the upstream "template" workflow and its installation in this repository.
umbynos
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Infrastructure update
We have assembled a collection of reusable GitHub Actions workflows:
https://github.com/arduino/tooling-project-assets
These workflows will be used in the repositories of all Arduino tooling projects.
Some minor improvements and standardizations have been made in the upstream "template" workflow, but those have not yet been pulled into this repository.
Workflow is synced with the state of the art from upstream.
Not breaking