Skip to content

[ATL-1253] replace reset implementation with the cli one, should be more robust #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix getting started failing if the board is in bootloader mode
  • Loading branch information
umbynos committed Apr 19, 2021
commit 0e6dea5c5392a20e38daacd1e3f2f4b2402cbc57
5 changes: 4 additions & 1 deletion upload/upload.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,14 @@ func Kill() {
// sometimes) and an error (usually because the port listing failed)
func reset(port string, wait bool, l Logger) (string, error) {
info(l, "Restarting in bootloader mode")
port, err := serialutils.Reset(port, wait, nil) // TODO use callbacks to print as the cli does
newPort, err := serialutils.Reset(port, wait, nil) // TODO use callbacks to print as the cli does
if err != nil {
info(l, err)
return "", err
}
if newPort != "" {
port = newPort
}
return port, nil
}

Expand Down