Skip to content

Deploy Make sure we don't lose an error #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2019
Merged

Deploy Make sure we don't lose an error #377

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad820d4
Make sure we don't lose an error
matteosuppo May 16, 2019
eb07e84
Merge pull request #376 from arduino/better_error
rsora May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make sure we don't lose an error
  • Loading branch information
@matteosuppo
matteosuppo committed May 16, 2019
commit ad820d40878d48c4896d04a49bcba1461a6b0a3e
3 changes: 3 additions & 0 deletions upload/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ func program(binary string, args []string, l Logger) error {
info(l, "Flashing with command:"+binary+extension+" "+strings.Join(args, " "))

err = cmd.Start()
if err != nil {
return errors.Wrapf(err, "Start command")
}

stdoutCopy := bufio.NewScanner(stdout)
stderrCopy := bufio.NewScanner(stderr)
Expand Down