Skip to content

Correct "setup-licensed" action ref in dependencies license check workflow #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use latest version of "github/setup-licensed" action
The "github/setup-licensed" action is used by the dependencies license check workflow to install the "Licensed" tool in
the runner machine.

Previously the `v1` major version ref of the action was specified in the workflow. This approach is used in order to
allow the workflow to automatically always use the latest minor version of the action, only requiring the project
maintainers to perform a bump of the action after each major version release.

In a competently maintained action project, the major version ref will be updated after each release within that major
version series so that it always points to the latest release version. Unfortunately that was not done by the
"github/setup-licensed" action maintainers. This means that the use of the `v1` ref in the workflow causes an outdated
version of the action to be used. This has been reported to the action maintainers, but unfortunately instead of fixing
the problem they archived the repository, so there is no hope of it being resolved.

The solution is to replace the major version ref with the ref for the latest release tag. This won't result in an
increased maintenance burden because the action repository is archived and thus there won't be any bumps.
  • Loading branch information
per1234 committed Mar 2, 2025
commit a9c6287f2d2fee5180a258a19c7e1687eb9b224a
2 changes: 1 addition & 1 deletion .github/workflows/check-go-dependencies-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
submodules: recursive

- name: Install licensed
uses: github/setup-licensed@v1
uses: github/setup-licensed@v1.3.1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x
Expand Down