Skip to content

Command placeholders #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matteosuppo opened this issue Jul 5, 2017 · 3 comments
Closed

Command placeholders #158

matteosuppo opened this issue Jul 5, 2017 · 3 comments
Assignees
Labels
conclusion: stale Closed due to lack of activity status: waiting for information More information must be provided before work can proceed

Comments

@matteosuppo
Copy link
Contributor

matteosuppo commented Jul 5, 2017

Now we only replace the port: https://github.com/arduino/arduino-create-agent/blob/devel/upload/upload.go#L78

But for more complex commands it could be useful a more flexible system.

Maybe instead of a command+signature we could send an encrypted json like

{
"command": "do stuff with $port and $fqbn",
"env": ["port", "env"]
}

Along with a non-encrypted json containing the actual value to be replaced:

{
 "commandline": "7bfe45p43lk....",
 "env": {
 "port": "COM4",
 "fqbn": "arduino:avr:uno"
 }
}

What do you think? Are there security issues that I don't see?
@zmoog
Copy link
Contributor

zmoog commented Jan 29, 2021

Why do we need to change the current command + signature mechanism with something different?

@zmoog zmoog added the status: waiting for information More information must be provided before work can proceed label Jan 29, 2021
@github-actions
Copy link

This issue has been marked as stale because it has been open 14 days with no activity. Remove stale label or comment, otherwise it will be closed in 7 days

@github-actions github-actions bot added the Stale label Feb 15, 2021
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

This issue has been closed becasue has been stale for 7 days. If you think this issue deserves some attention feel free to reopen it

@github-actions github-actions bot closed this as completed Mar 1, 2021
@rsora rsora added the conclusion: stale Closed due to lack of activity label Sep 22, 2021
@per1234 per1234 removed the Stale label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: stale Closed due to lack of activity status: waiting for information More information must be provided before work can proceed
Projects
None yet
Development

No branches or pull requests

5 participants