Move the function to download tools in a package

Download from http://downloads.arduino.cc/packages/package_index.json
Update the Installed Map at startup

Author: matteosuppo

docs/tools.md

@@ -0,0 +1,64 @@
+# tools
+--
+    import "github.com/arduino/arduino-create-agent/tools"
+
+
+## Usage
+
+#### type Tools
+
+```go
+type Tools struct {
+	Directory string
+	IndexURL  string
+	Logger    log.StdLogger
+}
+```
+
+Tools handle the tools necessary for an upload on a board. It provides a means
+to download a tool from the arduino servers.
+
+- *Directory* contains the location where the tools are downloaded.
+- *IndexURL* contains the url where the tools description is contained.
+- *Logger* is a StdLogger used for reporting debug and info messages
+- *installed* contains a map of the tools and their exact location
+
+Usage: You have to instantiate the struct by passing it the required parameters:
+
+    _tools := tools.Tools{
+        Directory: "/home/user/.arduino-create",
+        IndexURL: "http://downloads.arduino.cc/packages/package_index.json"
+        Logger: log.Logger
+    }
+
+#### func (*Tools) Download
+
+```go
+func (t *Tools) Download(name, version, behaviour string) error
+```
+Download will parse the index at the indexURL for the tool to download. It will
+extract it in a folder in .arduino-create, and it will update the Installed map.
+
+name contains the name of the tool. version contains the version of the tool.
+behaviour contains the strategy to use when there is already a tool installed
+
+If version is "latest" it will always download the latest version (regardless of
+the value of behaviour)
+
+If version is not "latest" and behaviour is "replace", it will download the
+version again. If instead behaviour is "keep" it will not download the version
+if it already exists.
+
+#### func (*Tools) GetLocation
+
+```go
+func (t *Tools) GetLocation(command string) (string, error)
+```
+GetLocation extracts the toolname from a command like
+
+#### func (*Tools) Init
+
+```go
+func (t *Tools) Init()
+```
+Init creates the Installed map and populates it from a file in .arduino-create

download.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 
 	log "github.com/Sirupsen/logrus"
-	"github.com/arduino/arduino-create-agent/tools"
 	"github.com/kardianos/osext"
 	//"os"
 	"os/exec"
@@ -192,8 +191,19 @@ func checkCmd(m []byte) {
 		go spList(true)
 	} else if strings.HasPrefix(sl, "downloadtool") {
 		args := strings.Split(s, " ")
-		if len(args) > 2 {
-			go tools.Download(args[1], args[2])
+		if len(args) > 1 {
+			go func() {
+				err := Tools.Download(args[1], "latest", "replace")
+				if err != nil {
+					mapD := map[string]string{"DownloadStatus": "Error", "Msg": err.Error()}
+					mapB, _ := json.Marshal(mapD)
+					h.broadcastSys <- mapB
+				} else {
+					mapD := map[string]string{"DownloadStatus": "Success", "Msg": "Map Updated"}
+					mapB, _ := json.Marshal(mapD)
+					h.broadcastSys <- mapB
+				}
+			}()
 		}
 	} else if strings.HasPrefix(sl, "bufferalgorithm") {
 		go spBufferAlgorithms()

hub.go

@@ -38,15 +38,15 @@ var (
 	gcType       = flag.String("gc", "std", "Type of garbage collection. std = Normal garbage collection allowing system to decide (this has been known to cause a stop the world in the middle of a CNC job which can cause lost responses from the CNC controller and thus stalled jobs. use max instead to solve.), off = let memory grow unbounded (you have to send in the gc command manually to garbage collect or you will run out of RAM eventually), max = Force garbage collection on each recv or send on a serial port (this minimizes stop the world events and thus lost serial responses, but increases CPU usage)")
 	logDump      = flag.String("log", "off", "off = (default)")
 	// hostname. allow user to override, otherwise we look it up
-	hostname       = flag.String("hostname", "unknown-hostname", "Override the hostname we get from the OS")
-	updateUrl      = flag.String("updateUrl", "", "")
-	appName        = flag.String("appName", "", "")
-	genCert        = flag.Bool("generateCert", false, "")
-	globalToolsMap = make(map[string]string)
-	port           string
-	portSSL        string
-	origins        = flag.String("origins", "", "Allowed origin list for CORS")
-	address        = flag.String("address", "127.0.0.1", "The address where to listen. Defaults to localhost")
+	hostname  = flag.String("hostname", "unknown-hostname", "Override the hostname we get from the OS")
+	updateUrl = flag.String("updateUrl", "", "")
+	appName   = flag.String("appName", "", "")
+	genCert   = flag.Bool("generateCert", false, "")
+	port      string
+	portSSL   string
+	origins   = flag.String("origins", "", "Allowed origin list for CORS")
+	address   = flag.String("address", "127.0.0.1", "The address where to listen. Defaults to localhost")
+	Tools     tools.Tools
 )
 
 type NullWriter int
@@ -89,7 +89,13 @@ func main() {
 			src, _ := osext.Executable()
 			dest := filepath.Dir(src)
 
-			tools.CreateDir()
+			// Instantiate Tools
+			Tools = tools.Tools{
+				Directory: "/home/user/.arduino-create",
+				IndexURL:  "http://downloads.arduino.cc/packages/package_index.json",
+				Logger:    log.New(),
+			}
+			Tools.Init()
 
 			if embedded_autoextract {
 				// save the config.ini (if it exists)

main.go

@@ -5,11 +5,6 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	log "github.com/Sirupsen/logrus"
-	"github.com/facchinm/go-serial"
-	"github.com/mattn/go-shellwords"
-	"github.com/sfreiberg/simplessh"
-	"github.com/xrash/smetrics"
 	"io"
 	"mime/multipart"
 	"net/http"
@@ -21,6 +16,11 @@ import (
 	"strconv"
 	"strings"
 	"time"
+
+	log "github.com/Sirupsen/logrus"
+	"github.com/facchinm/go-serial"
+	"github.com/mattn/go-shellwords"
+	"github.com/sfreiberg/simplessh"
 )
 
 var compiling = false
@@ -231,23 +231,16 @@ func spProgramLocal(portname string, boardname string, filePath string, commandl
 	var runtimeRe = regexp.MustCompile("\\{(.*?)\\}")
 	runtimeVars := runtimeRe.FindAllString(commandline, -1)
 
-	fmt.Println(runtimeVars)
-
 	for _, element := range runtimeVars {
 
-		// use string similarity to resolve a runtime var with a "similar" map element
-		if globalToolsMap[element] == "" {
-			max_similarity := 0.0
-			for i, candidate := range globalToolsMap {
-				similarity := smetrics.Jaro(element, i)
-				if similarity > 0.8 && similarity > max_similarity {
-					max_similarity = similarity
-					globalToolsMap[element] = candidate
-				}
-			}
+		location, err := Tools.GetLocation(element)
+		if err != nil {
+			log.Printf("Command finished with error: %v", err)
+			mapD := map[string]string{"ProgrammerStatus": "Error", "Msg": "Could not find the upload tool"}
+			mapB, _ := json.Marshal(mapD)
+			h.broadcastSys <- mapB
 		}
-
-		commandline = strings.Replace(commandline, element, globalToolsMap[element], 1)
+		commandline = strings.Replace(commandline, element, location, 1)
 	}
 
 	z, _ := shellwords.Parse(commandline)
@@ -291,7 +284,6 @@ func spProgramRW(portname string, boardname string, filePath string, commandline
 var oscmd *exec.Cmd
 
 func spHandlerProgram(flasher string, cmdString []string) error {
-
 	// if runtime.GOOS == "darwin" {
 	// 	sh, _ := exec.LookPath("sh")
 	// 	// prepend the flasher to run it via sh
@@ -391,7 +383,6 @@ func formatCmdline(cmdline string, boardOptions map[string]string) (string, bool
 			}
 		}
 	}
-	log.Println(cmdline)
 	return cmdline, true
 }