Revert "fix stupid bug on serial buffering routine"

This reverts commit 616d5aa.

Revert "try to avoid out-of-bound read on abrupt serial event"

This reverts commit 0e65d13.

Revert "Append buffered bytes only if read() was successful"

This reverts commit 72bcdc1.

Author: facchinm

serialport.go

@@ -103,15 +103,6 @@ func (p *serport) reader() {
 
 		n, err := p.portIo.Read(ch)
 
-		if err == nil {
-			if n > len(ch) {
-				n = len(ch)
-			}
-			ch = append(buffered_ch.Bytes(), ch[:n-1]...)
-			n += len(buffered_ch.Bytes())
-			buffered_ch.Reset()
-		}
-
 		//if we detect that port is closing, break out o this for{} loop.
 		if p.isClosing {
 			strmsg := "Shutting down reader on " + p.portConf.Name
@@ -120,6 +111,10 @@ func (p *serport) reader() {
 			break
 		}
 
+		ch = append(buffered_ch.Bytes(), ch[:n]...)
+		n += len(buffered_ch.Bytes())
+		buffered_ch.Reset()
+
 		// read can return legitimate bytes as well as an error
 		// so process the bytes if n > 0
 		if n > 0 {