move TellCommandNotToSpawnShell to tools package

Author: facchinm

programmer.go

@@ -17,6 +17,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/arduino/arduino-create-agent/tools"
+
 	log "github.com/Sirupsen/logrus"
 	"github.com/facchinm/go-serial"
 	"github.com/mattn/go-shellwords"
@@ -305,7 +307,7 @@ func spHandlerProgram(flasher string, cmdString []string) error {
 
 	oscmd = exec.Command(flasher, cmdString...)
 
-	tellCommandNotToSpawnShell(oscmd)
+	tools.TellCommandNotToSpawnShell(oscmd)
 
 	stdout, err := oscmd.StdoutPipe()
 	if err != nil {

seriallist_darwin.go

@@ -64,6 +64,3 @@ func associateVidPidWithPort(ports []OsSerialPort) []OsSerialPort {
 	}
 	return ports
 }
-
-func tellCommandNotToSpawnShell(_ *exec.Cmd) {
-}

seriallist_linux.go

@@ -34,6 +34,3 @@ func associateVidPidWithPort(ports []OsSerialPort) []OsSerialPort {
 	}
 	return ports
 }
-
-func tellCommandNotToSpawnShell(_ *exec.Cmd) {
-}

seriallist_windows.go

@@ -2,11 +2,9 @@ package main
 
 import (
 	"os"
-	"os/exec"
 	"regexp"
 	"strings"
 	"sync"
-	"syscall"
 
 	log "github.com/Sirupsen/logrus"
 	"github.com/mattn/go-ole"
@@ -227,7 +225,3 @@ func convertByteArrayToUint16Array(b []byte, mylen uint32) []uint16 {
 	}
 	return ret
 }
-
-func tellCommandNotToSpawnShell(oscmd *exec.Cmd) {
-	oscmd.SysProcAttr = &syscall.SysProcAttr{HideWindow: true}
-}

tools/hidefile_darwin.go

@@ -1,5 +1,12 @@
 package tools
 
+import (
+	"os/exec"
+)
+
 func hideFile(path string) {
 
 }
+
+func TellCommandNotToSpawnShell(_ *exec.Cmd) {
+}

tools/hidefile_linux.go

@@ -1,5 +1,12 @@
 package tools
 
+import (
+	"os/exec"
+)
+
 func hideFile(path string) {
 
 }
+
+func TellCommandNotToSpawnShell(_ *exec.Cmd) {
+}

tools/hidefile_windows.go

@@ -1,10 +1,17 @@
 package tools
 
-import "syscall"
+import (
+	"os/exec"
+	"syscall"
+)
 
 func hideFile(path string) {
 	cpath, cpathErr := syscall.UTF16PtrFromString(path)
 	if cpathErr != nil {
 	}
 	syscall.SetFileAttributes(cpath, syscall.FILE_ATTRIBUTE_HIDDEN)
 }
+
+func TellCommandNotToSpawnShell(oscmd *exec.Cmd) {
+	oscmd.SysProcAttr = &syscall.SysProcAttr{HideWindow: true}
+}