Skip to content

snap #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

snap #281

wants to merge 3 commits into from

Conversation

mikeroyal
Copy link

Includes a snapcraft.yaml to build snap. I still need to make some changes to the snap configuration but here's what i have so far.

Prep

sudo snap install snapcraft --classic
sudo snap install multipass --beta --classic

Includes a snapcraft.yaml to build [snap](https://snapcraft.io/). I still need to make some changes to the snap configuration but here's what i have so far.
# Prep
sudo snap install snapcraft --classic
sudo snap install multipass --beta --classic
@CLAassistant
Copy link

CLAassistant commented Jul 16, 2019

CLA assistant check
All committers have signed the CLA.

@mikeroyal
Copy link
Author

cla signed.

@masci
Copy link
Contributor

masci commented Jul 17, 2019

Hi @mikeroyal,

providing the CLI package via Snap is something on the roadmap so this PR is gold, thanks!

There's one thing I'd like to discuss before merging: we were planning to use goreleaser to be able to support multiple distribution channels with one single tool to ease maintenance. Since I'm no snap expert, It'd be great if you could have a look at the Snap specific section of their docs to see if your work can be integrated with it.

@masci masci self-assigned this Jul 17, 2019
@mikeroyal
Copy link
Author

mikeroyal commented Jul 17, 2019

Hi @masci, goreleaser is indeed supported for snap. https://goreleaser.com/snapcraft/

@masci
Copy link
Contributor

masci commented Jul 18, 2019

@mikeroyal do you think you can take a stab at using gorelaser to make the snap? Otherwise I can start playing with it and we can add snap later.

@mikeroyal
Copy link
Author

@masci, I'll work on it over the weekend.

Still need to configure some variables but the general description and layout for the snap is setup in the .yml file.
@masci
Copy link
Contributor

masci commented Jul 31, 2019

@mikeroyal we merged a working goreleaser config file on master, if you rebase you can add a Snap section to it

@mikeroyal
Copy link
Author

Hi @masci, will do and thank you for creating the goreleaser config file with all the requirements it makes adding the snap section a lot easier.

@masci masci added this to the 0.5.0 milestone Aug 2, 2019
Removing as their is already a working version in the master.
@mikeroyal
Copy link
Author

mikeroyal commented Aug 5, 2019

Hi @masci, I tried rebasing and GitHub was giving me an error. I'll again tomorrow but in the mean time here's the snapcraft section for the goreleaser.yml file if you want to take a look at it.

snapcraft:
  name_template: '{{ .ProjectName }}_{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}'
  summary: CLI for Arduino.
  description: |
    arduino-cli is an all-in-one solution that provides builder, boards/library manager, uploader, discovery and many other tools   	needed to use any Arduino compatible board and platforms.
  confinement: devmode
  base: core18

 apps:
      audrino-cli:
        plugs: ["home", "network", "removable-media"]
  publish: true

@masci masci removed this from the 0.5.0 milestone Aug 30, 2019
@masci masci added the status: in progress Work is in progress on this label Nov 6, 2019
@rsora
Copy link
Contributor

rsora commented Mar 26, 2020

Hi @mikeroyal ,
Do you have any update on this?

Please note that we had to change our approach on using goreleaser in the last months (i.e. to support notarization in our CI) so, we do not use goreleaser packaging features anymore.

@mikeroyal
Copy link
Author

mikeroyal commented Mar 30, 2020

Hi @rsora, I saw that update so it looks like you are using GitHub Actions? If so that actually works well for snaps. Snaps can now easily integrate with GitHub Actions to automate the whole process.

@per1234 per1234 added the type: enhancement Proposed improvement label Feb 3, 2021
@github-actions github-actions bot closed this Mar 30, 2021
@per1234 per1234 reopened this Mar 30, 2021
@rsora rsora added the topic: packaging Related to the release distribution package label Sep 22, 2021
@per1234 per1234 assigned ubidefeo and rsora and unassigned masci Nov 19, 2021
@umbynos
Copy link
Contributor

umbynos commented Aug 9, 2022

Hi @mikeroyal, @manchoz already managed to distribute the Arduino CLI as a snap: https://github.com/manchoz/arduino-cli-snap If you are ok with it I think we can close this one.

@umbynos umbynos self-assigned this Aug 9, 2022
@umbynos umbynos added status: waiting for information More information must be provided before work can proceed and removed status: in progress Work is in progress on this labels Aug 9, 2022
@cmaglie
Copy link
Member

cmaglie commented Sep 21, 2022

Hi @mikeroyal as already said, you can collaborate with @manchoz to maintain the arduino-cli snap package.

@cmaglie cmaglie closed this Sep 21, 2022
@per1234 per1234 added conclusion: declined Will not be worked on and removed status: waiting for information More information must be provided before work can proceed labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: packaging Related to the release distribution package type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants