Skip to content

Move types package under arduino #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Move types package under arduino #262

wants to merge 3 commits into from

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 2, 2019 •
edited
Loading

Part of the undergoing work to clean up and extract code from the legacy package, this PR moves the types package under the arduino one along with:

  • removing dead code
  • adding unit tests for each type that was moved under arduino/types
  • adding docstrings for the exported types

@arduino arduino deleted a comment from ArduinoBot Jul 2, 2019
@masci masci marked this pull request as ready for review July 3, 2019 09:32
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-143-PR262-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-143-PR262-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-143-PR262-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-143-PR262-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-143-PR262-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@arduino arduino deleted a comment from ArduinoBot Jul 3, 2019
@masci masci added the status: on hold Do not proceed at this time label Jul 4, 2019
@masci
Copy link
Contributor Author

masci commented Jul 9, 2019

Closing in favor of a complete refactoring of the Command pattern

@masci masci closed this Jul 9, 2019
@per1234 per1234 deleted the massi/types branch May 4, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: on hold Do not proceed at this time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masci @ArduinoBot