Move i18n package outside legacy

[masci]

Package is used in arduino root package, let's be explicity about it not being legacy.

[ArduinoBot]

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-63-PR246-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-63-PR246-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-63-PR246-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-63-PR246-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-63-PR246-osx.zip

ℹ️ To test this build:

1. Just replace arduino-cli binary with the provided one

[cmaglie]

mmmh, IMHO just moving i18n outside of legacy is not enough to promote it to "non-legacy", there is a lot of non-idiomatic golang code there (the failing linter is also a signal of this).

Where is it referenced in arduino/*? I can't find it...

[masci]

@cmaglie https://github.com/arduino/arduino-cli/blob/master/commands/compile/compile.go#L35

[cmaglie]

That is the commands/compile (not arduino) that depends on legacy/builder to perform the build. The dependency tree is:

commands/compile -> legacy/builder/* -> arduino/*

Again, legacy/builder has a ton of non trivial stuff that needs a bit of refactoring before being integrated in arduino/*.

[masci]

going to tackle this more organically, closing for now