Introduce new testing layout #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteosuppo
approved these changes
Jun 6, 2019
auth/auth_test.go
Outdated
| @@ -49,7 +57,7 @@ func TestToken(t *testing.T) { | |||
| } | |||
|
|
|||
| // Obtain info | |||
| req, err := http.NewRequest("GET", "https://auth.arduino.cc/v1/users/byID/me", nil) | |||
| req, err := http.NewRequest("GET", "https://ddauth.arduino.cc/v1/users/byID/me", nil) | |||
There was a problem hiding this comment.
(for context, tests are green because this specific test is skipped on Travis, found out when it was too late)
mastrolinux
pushed a commit
that referenced
this pull request
Jul 16, 2019
Introduce new testing layout
per1234
added a commit
that referenced
this pull request
Aug 9, 2021
Replace broken website publishing script link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The project currently has a robust test suite that exercises most of the functionalities against the actual http API. This is not very suitable to iterate fast on the code, thus this PR introduces the concept of unit tests in addition to the existing suite that will stay as it is but will be marked as "integration tests".
Implementation
Integration test functions will contain the string
Integrationin the name, so that the suite can be run withgo test -run integration ./.... Integration tests will be skipped when running unit tests and we use theshortoption from the Go standard lib to make this easy: each test function will begin like this:This way, unit tests will be run with just
go test -short ./...To make easier for contributors and the CI to run either of the suites, or both in sequence, a task runner was added.
taskis written in Go and can be easily installed by justgo getso it should be fair to ask developers to have it in their dev env. Available tasks are defined in theTaskfile.ymlfile, with this PR you can dotask test-unitto run all the unit tests, or (for example)task test-unit TARGETS=./authto run all the unit tests for theauthpackage only.task test-integrationis symmetric whiletask testwill run both integration and unit tests.Note that
go test ./...will keep running all the tests so the use oftaskis not mandatory.