-
-
Notifications
You must be signed in to change notification settings - Fork 406
Global build vars #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global build vars #226
Conversation
I'm not sure about injecting values via ldflags, this is not very idiomatic. If someone builds the cli from source with Maybe we can keep the version hardcoded? it could be overriden by the CI anyway, so we get the best of the two approaches. |
d125de3
to
0408a77
Compare
783ebaa
to
e2c413c
Compare
PR #227 is built upon this PR with heavy refactoring of the content. In agreement with the colleagues this PR will be closed |
Sync "Spell Check" CI workflow with template
This PR aims to refactor a group of global variables in a
global
package in order to inject values at build time and use them in the CLI section of the cliIn order to have the values injected the use of
-ldflags
param is required in thego build
phase otherwise amissing
value will be shown (so an update in our CI is mandatory)i.e. to inject the version value