Skip to content

Removed useless version param on 'core uninstall' #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 4, 2019

/cc @per1234

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed:

//Version: "1.6.19",


This line:

Use: "uninstall PACKAGER:ARCH[@VERSION] ...",

Should be changed to:

		Use:     "uninstall PACKAGER:ARCH ...",

@cmaglie cmaglie force-pushed the remove-useless-version-param branch from 71a8b57 to 4b59605 Compare June 5, 2019 15:47
@arduino arduino deleted a comment from ArduinoBot Jun 5, 2019
@cmaglie cmaglie requested a review from per1234 June 5, 2019 15:49
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't actually test this due to the issue I reported in CLI-15, but I am satisfied that my requested changes were made. Thanks!

@cmaglie cmaglie merged commit db4c149 into arduino:master Jun 5, 2019
@cmaglie cmaglie added this to the next alpha milestone Jun 5, 2019
@cmaglie cmaglie deleted the remove-useless-version-param branch June 5, 2019 16:35
per1234 added a commit that referenced this pull request Aug 9, 2021
Run Go module configuration sync check also on docsgen module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants