Provide package indexes from file paths using "additional-paths" flag #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
giulcioffi
force-pushed
the
Absolute_path
branch
from
73901b4 to
00f9d35
Compare
silvanocerza
reviewed
Dec 1, 2020
| @@ -104,6 +104,7 @@ func createCliCommandTree(cmd *cobra.Command) { | |||
| cmd.PersistentFlags().StringVar(&outputFormat, "format", "text", "The output format, can be {text|json}.") | |||
| cmd.PersistentFlags().StringVar(&configFile, "config-file", "", "The custom config file (if not specified the default will be used).") | |||
| cmd.PersistentFlags().StringSlice("additional-urls", []string{}, "Comma-separated list of additional URLs for the Boards Manager.") | |||
| cmd.PersistentFlags().StringSlice("additional-paths", []string{}, "Comma-separated list of additional file paths for the Boards Manager.") | |||
There was a problem hiding this comment.
You need to add this new key also in cli/config/validate.go, otherwise you won't be able to edit from the CLI.
See #1082
silvanocerza
reviewed
Dec 1, 2020
commands/instances.go
Outdated
| jsonPaths := []string{} | ||
| jsonPaths = append(jsonPaths, configuration.Settings.GetStringSlice("board_manager.additional_paths")...) | ||
|
|
||
| for _, x := range jsonPaths { |
There was a problem hiding this comment.
You're not using jsonPaths anywhere else other than the for, you could do this to simplify:
for _, x := range configuration.Settings.GetStringSlice("board_manager.additional_paths") {
Same thing for the other in createInstance().
silvanocerza
suggested changes
Dec 1, 2020
giulcioffi
force-pushed
the
Absolute_path
branch
from
00f9d35 to
7fc92e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
It introduces a new flag
additional-pathsthat allows to provide package indexes from absolute file paths. In this case, the signature will not be checked. This can be useful for third party cores, since they will not be requested to upload their package indexes to a server. However it can also be useful for Arduino internal usage during testing phases.Package indexes can be downloaded only from URL. In case of Arduino cores, the signature is always checked and if a valid signature is not found, the core installation fails. There is no way to test a new Arduino package index that has no signature yet.
Package indexes can be provided also from the absolute file path and the signature will not be checked. An Arduino package index without a signature can be provided in this way.
No, it does not. It introduces a new feature that should not impact on the already implemented ones.
This PR will be needed for the Arduino core release automation workflow. Tests on the core with arduino-cli will need to run when there is no signature yet.
See how to contribute