Skip to content

Commit bdf3772

Browse files
committed
Do not bail out for missing 'core' index on 'lib' commands
1 parent eab7ad5 commit bdf3772

File tree

9 files changed

+15
-8
lines changed

9 files changed

+15
-8
lines changed

cli/cli.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,13 @@ func CreateInstance() *rpc.Instance {
131131
return resp.GetInstance()
132132
}
133133

134+
// CreateLibManagerOnlyInstace creates and return an instance of the
135+
// Arduino Core Engine skipping the platform manager initialization (only
136+
// libraries management enabled).
137+
func CreateLibManagerOnlyInstace() *rpc.Instance {
138+
return InitInstance(true).GetInstance()
139+
}
140+
134141
// InitPackageAndLibraryManager initializes the PackageManager and the
135142
// LibaryManager with the default configuration. (DEPRECATED)
136143
func InitPackageAndLibraryManager() (*packagemanager.PackageManager, *librariesmanager.LibrariesManager) {

cli/lib/download.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func initDownloadCommand() *cobra.Command {
4545
}
4646

4747
func runDownloadCommand(cmd *cobra.Command, args []string) {
48-
instance := cli.CreateInstance()
48+
instance := cli.CreateLibManagerOnlyInstace()
4949
pairs, err := librariesindex.ParseArgs(args)
5050
if err != nil {
5151
formatter.PrintError(err, "Arguments error")

cli/lib/install.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func initInstallCommand() *cobra.Command {
4545
}
4646

4747
func runInstallCommand(cmd *cobra.Command, args []string) {
48-
instance := cli.CreateInstance()
48+
instance := cli.CreateLibManagerOnlyInstace()
4949
refs, err := librariesindex.ParseArgs(args)
5050
if err != nil {
5151
formatter.PrintError(err, "Arguments error")

cli/lib/list.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ var listFlags struct {
5151
}
5252

5353
func runListCommand(cmd *cobra.Command, args []string) {
54-
instance := cli.CreateInstance()
54+
instance := cli.CreateLibManagerOnlyInstace()
5555
logrus.Info("Listing")
5656

5757
res, err := lib.LibraryList(context.Background(), &rpc.LibraryListReq{

cli/lib/search.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ var searchFlags struct {
5252
}
5353

5454
func runSearchCommand(cmd *cobra.Command, args []string) {
55-
instance := cli.CreateInstance()
55+
instance := cli.CreateLibManagerOnlyInstace()
5656
logrus.Info("Executing `arduino lib search`")
5757
//arguments :=
5858
searchResp, err := lib.LibrarySearch(context.Background(), &rpc.LibrarySearchReq{

cli/lib/uninstall.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func initUninstallCommand() *cobra.Command {
4545
func runUninstallCommand(cmd *cobra.Command, args []string) {
4646
logrus.Info("Executing `arduino lib uninstall`")
4747

48-
instance := cli.CreateInstance()
48+
instance := cli.CreateLibManagerOnlyInstace()
4949
libRefs, err := librariesindex.ParseArgs(args)
5050
if err != nil {
5151
formatter.PrintError(err, "Arguments error")

cli/lib/update_index.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func initUpdateIndexCommand() *cobra.Command {
3636
Example: " " + cli.AppName + " lib update-index",
3737
Args: cobra.NoArgs,
3838
Run: func(cmd *cobra.Command, args []string) {
39-
instance := cli.CreateInstance()
39+
instance := cli.CreateLibManagerOnlyInstace()
4040
err := commands.UpdateLibrariesIndex(context.Background(), &rpc.UpdateLibrariesIndexReq{
4141
Instance: instance,
4242
}, cli.OutputProgressBar())

cli/lib/upgrade.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func initUpgradeCommand() *cobra.Command {
4343
}
4444

4545
func runUpgradeCommand(cmd *cobra.Command, args []string) {
46-
instance := cli.CreateInstance()
46+
instance := cli.CreateLibManagerOnlyInstace()
4747

4848
err := lib.LibraryUpgradeAll(context.Background(), &rpc.LibraryUpgradeAllReq{
4949
Instance: instance,

commands/lib/search.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ func LibrarySearch(ctx context.Context, req *rpc.LibrarySearchReq) (*rpc.Library
7070

7171
return &rpc.LibrarySearchResp{SearchOutput: res}, nil
7272
}
73-
func GetLibraryParameters(rel *librariesindex.Release) *rpc.LibraryRelease {
7473

74+
func GetLibraryParameters(rel *librariesindex.Release) *rpc.LibraryRelease {
7575
return &rpc.LibraryRelease{
7676
Author: rel.Author,
7777
Version: rel.Version.String(),

0 commit comments

Comments
 (0)