fix regressions: use correct exit code when error occurs

Author: cmaglie

cli/cli_test.go

@@ -556,6 +556,8 @@ board_manager:
 	require.NoError(t, err, "Writing empty json index file")
 	err = currDataDir.Join("package_example_index.json").WriteFile([]byte(`{ "packages": [] }`))
 	require.NoError(t, err, "Writing empty json index file")
+	err = currDataDir.Join("library_index.json").WriteFile([]byte(`{ "libraries": [] }`))
+	require.NoError(t, err, "Writing empty json index file")
 
 	// Empty cores list
 	exitCode, d := executeWithArgs(t, "--config-file", configFile.String(), "core", "list")

cli/core/download.go

@@ -19,6 +19,7 @@ package core
 
 import (
 	"context"
+	"os"
 
 	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/commands/core"
@@ -56,6 +57,7 @@ func runDownloadCommand(cmd *cobra.Command, args []string) {
 		}, cli.OutputProgressBar())
 		if err != nil {
 			formatter.PrintError(err, "Error downloading "+platformRef.String())
+			os.Exit(cli.ErrNetwork)
 		}
 	}
 }

cli/core/uninstall.go

@@ -19,9 +19,11 @@ package core
 
 import (
 	"context"
+	"os"
 
 	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/commands/core"
+	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/output"
 	"github.com/arduino/arduino-cli/rpc"
 	"github.com/sirupsen/logrus"
@@ -46,11 +48,15 @@ func runUninstallCommand(cmd *cobra.Command, args []string) {
 	platformsRefs := parsePlatformReferenceArgs(args)
 
 	for _, platformRef := range platformsRefs {
-		core.PlatformUninstall(context.Background(), &rpc.PlatformUninstallReq{
+		_, err := core.PlatformUninstall(context.Background(), &rpc.PlatformUninstallReq{
 			Instance:        instance,
 			PlatformPackage: platformRef.Package,
 			Architecture:    platformRef.PlatformArchitecture,
 			Version:         platformRef.PlatformVersion.String(),
 		}, output.NewTaskProgressCB())
+		if err != nil {
+			formatter.PrintError(err, "Error during uninstall")
+			os.Exit(cli.ErrGeneric)
+		}
 	}
 }