Skip to content

Archive compiled core and use on subsequent compilations #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 20, 2017
Merged

Archive compiled core and use on subsequent compilations #213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b3303ce
Added FQBN in the buildProperties
cmaglie Mar 1, 2017
e36af02
[WIP] Archive compiled core and use in any compatible project
cmaglie Mar 1, 2017
1b629fd
Fix tests that fails when core.a caching is enabled
facchinm Feb 10, 2017
2444448
Recreate the archive if ANY of the core files (including platform.txt…
facchinm Feb 10, 2017
40372d7
Check for modifications also in referenced core
facchinm Feb 16, 2017
19751fe
Generalize core changes checking routine
facchinm Mar 1, 2017
61a81f9
Added test for core caching
cmaglie Mar 2, 2017
ca9f34d
Cached core.a filename now depends on core path too
cmaglie Mar 3, 2017
0448b73
Factored setup of builder tests
cmaglie Mar 3, 2017
4764159
The build caching of core.a is now optional thorugh a command line op…
cmaglie Mar 3, 2017
4591ba3
Simplified builder test
cmaglie Mar 3, 2017
1125e53
Remove TestWipeoutBuildPathIfBuildOptionsChangedBuildOptionsMatch test
facchinm Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added FQBN in the buildProperties 
Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
  • Loading branch information
@cmaglie
cmaglie committed Mar 1, 2017
commit b3303ce57b3e6f076ebebf2d8e27045816c2481c
6 changes: 6 additions & 0 deletions src/arduino.cc/builder/builder_utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,3 +366,9 @@ func ExecRecipeCollectStdErr(buildProperties properties.Map, recipe string, remo
func RemoveHyphenMDDFlagFromGCCCommandLine(buildProperties properties.Map) {
buildProperties[constants.BUILD_PROPERTIES_COMPILER_CPP_FLAGS] = strings.Replace(buildProperties[constants.BUILD_PROPERTIES_COMPILER_CPP_FLAGS], "-MMD", "", -1)
}

func GetCoreArchivePath(fqbn string) string {
fqbnToUnderscore := strings.Replace(fqbn, ":", "_", -1)
fqbnToUnderscore = strings.Replace(fqbnToUnderscore, "=", "_", -1)
return os.TempDir() + "/core_" + fqbnToUnderscore + ".a"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good idea to put these files directly in the tempdir? Also, shouldn't these files be cleaned up at some point (e.g. when the IDE exits)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a temporary way to store them 😄 A proper db (or folder structure) is surely the way to go

}
1 change: 1 addition & 0 deletions src/arduino.cc/builder/constants/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ const BUILD_PROPERTIES_EXTRA_TIME_DST = "extra.time.dst"
const BUILD_PROPERTIES_EXTRA_TIME_LOCAL = "extra.time.local"
const BUILD_PROPERTIES_EXTRA_TIME_UTC = "extra.time.utc"
const BUILD_PROPERTIES_EXTRA_TIME_ZONE = "extra.time.zone"
const BUILD_PROPERTIES_FQBN = "build.fqbn"
const BUILD_PROPERTIES_INCLUDES = "includes"
const BUILD_PROPERTIES_OBJECT_FILE = "object_file"
const BUILD_PROPERTIES_OBJECT_FILES = "object_files"
Expand Down
1 change: 1 addition & 0 deletions src/arduino.cc/builder/setup_build_properties.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ func (s *SetupBuildProperties) Run(ctx *types.Context) error {
buildProperties[constants.BUILD_PROPERTIES_RUNTIME_PLATFORM_PATH] = targetPlatform.Folder
buildProperties[constants.BUILD_PROPERTIES_RUNTIME_HARDWARE_PATH] = filepath.Join(targetPlatform.Folder, "..")
buildProperties[constants.BUILD_PROPERTIES_RUNTIME_IDE_VERSION] = ctx.ArduinoAPIVersion
buildProperties[constants.BUILD_PROPERTIES_FQBN] = ctx.FQBN
buildProperties[constants.IDE_VERSION] = ctx.ArduinoAPIVersion
buildProperties[constants.BUILD_PROPERTIES_RUNTIME_OS] = utils.PrettyOSName()

Expand Down