Skip to content

Avoid breaking the build if broken symlinks found #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Avoid breaking the build if broken symlinks found
Fixes #159, please make sure that it doesn't introduce any regression

Tests are passing on Linux but something nasty could happen on different OS

Signed-off-by: Martino Facchin <m.facchin@arduino.cc>
  • Loading branch information
facchinm committed Jul 7, 2016
commit dfa7167dcb1f06a544736d84d0c7b70ee4cfd39d
3 changes: 2 additions & 1 deletion src/arduino.cc/builder/gohasissues/go_has_issues.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ func ReadDir(dirname string) ([]os.FileInfo, error) {
for idx, info := range infos {
info, err := resolveSymlink(dirname, info)
if err != nil {
return nil, err
// unresolvable symlinks should be skipped silently
return nil, nil
}
infos[idx] = info
}
Expand Down